Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Identified issues with JRuby RSpec failures and marked them as pending under java. #274

Merged
merged 3 commits into from

2 participants

@akiellor

This should make the 1.6.5 and 1.6.6 build pass. 1.6.7 still has some unicode issues I'm tracking down.

@mattwynne mattwynne merged commit 6ed5f60 into cucumber:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
14 spec/cucumber/cli/configuration_spec.rb
@@ -404,14 +404,20 @@ def reset_config
end
describe "#tag_expression" do
+ include RSpec::WorkInProgress
+
it "returns an empty expression when no tags are specified" do
- config.parse!([])
- config.tag_expression.should be_empty
+ pending_under :java, 'the java class Gherkin::TagExpression has no isEmpty method' do
+ config.parse!([])
+ config.tag_expression.should be_empty
+ end
end
it "returns an expression when tags are specified" do
- config.parse!(['--tags','@foo'])
- config.tag_expression.should_not be_empty
+ pending_under :java, 'the java class Gherkin::TagExpression has no isEmpty method' do
+ config.parse!(['--tags','@foo'])
+ config.tag_expression.should_not be_empty
+ end
end
end
View
12 spec/cucumber/cli/options_spec.rb
@@ -55,14 +55,20 @@ def after_parsing(args)
context '--i18n' do
context "with LANG specified as 'help'" do
+ include RSpec::WorkInProgress
+
it "lists all known langues" do
- when_parsing '--i18n help' do
- Kernel.should_receive(:exit)
+ pending_under :java, "require gherkin >= b5e96f13" do
+ when_parsing '--i18n help' do
+ Kernel.should_receive(:exit)
+ end
end
end
it "exits the program" do
- when_parsing('--i18n help') { Kernel.should_receive(:exit) }
+ pending_under :java, "require gherkin >= b5e96f13" do
+ when_parsing('--i18n help') { Kernel.should_receive(:exit) }
+ end
end
end
end
View
8 spec/cucumber/rb_support/regexp_argument_matcher_spec.rb
@@ -4,14 +4,18 @@
module Cucumber
module RbSupport
describe RegexpArgumentMatcher do
+ include RSpec::WorkInProgress
+
it "should create 2 arguments" do
arguments = RegexpArgumentMatcher.arguments_from(/I (\w+) (\w+)/, "I like fish")
arguments.map{|argument| [argument.val, argument.offset]}.should == [["like", 2], ["fish", 7]]
end
it "should create 2 arguments when first group is optional" do
- arguments = RegexpArgumentMatcher.arguments_from(/should( not)? be flashed '([^']*?)'$/, "I should be flashed 'Login failed.'")
- arguments.map{|argument| [argument.val, argument.offset]}.should == [[nil, nil], ["Login failed.", 21]]
+ pending_under :java, "requires cucumber/gherkin >= ac42f51" do
+ arguments = RegexpArgumentMatcher.arguments_from(/should( not)? be flashed '([^']*?)'$/, "I should be flashed 'Login failed.'")
+ arguments.map{|argument| [argument.val, argument.offset]}.should == [[nil, nil], ["Login failed.", 21]]
+ end
end
end
end
View
8 spec/cucumber/step_match_spec.rb
@@ -5,6 +5,8 @@
module Cucumber
describe StepMatch do
+ include RSpec::WorkInProgress
+
WORD = Cucumber::RUBY_1_9 ? '[[:word:]]' : '\w'
before do
@@ -57,8 +59,10 @@ def step_match(regexp, name)
end
it "should format groups even when first group is optional and not matched" do
- m = step_match(/should( not)? be flashed '([^']*?)'$/, "I should be flashed 'Login failed.'")
- m.format_args("<span>%s</span>").should == "I should be flashed '<span>Login failed.</span>'"
+ pending_under :java, "requires cucumber/gherkin >= ac42f51" do
+ m = step_match(/should( not)? be flashed '([^']*?)'$/, "I should be flashed 'Login failed.'")
+ m.format_args("<span>%s</span>").should == "I should be flashed '<span>Login failed.</span>'"
+ end
end
it "should format embedded groups" do
View
14 spec/spec_helper.rb
@@ -20,3 +20,17 @@
::Cucumber::Term::ANSIColor.coloring = true
end
end
+
+module RSpec
+ module WorkInProgress
+ def pending_under platforms, reason, &block
+ if [platforms].flatten.map(&:to_s).include? RUBY_PLATFORM
+ pending "pending under #{platforms.inspect} because: #{reason}", &block
+ else
+ yield
+ end
+ end
+ end
+end
+
+
Something went wrong with that request. Please try again.