gherkin java: Improved contributing documentation #314

merged 1 commit into from Dec 6, 2017


None yet
2 participants

tsundberg commented Dec 6, 2017


The wasn't clear on how to contribute.


I updated the reference to the that was missing. It pointed towards an old file in cucumber/gherkin.

The repository to clone was cucumber/gherkin which is obsolete. I changed it to say cucumber/cucumber instead.

Motivation and Context

The documentation confused me when I wanted to share another pull request. I thought I better update the documentation when I noticed the problem.

How Has This Been Tested?

I have done manual testing to verify that the updated links ends up where I expected them to end up.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).


  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mpkorstanje mpkorstanje merged commit 32cb274 into master Dec 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@mpkorstanje mpkorstanje deleted the clone-the-proper-repo-when-contributing branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment