Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes #335 #336
After contemplating on the "
variable or ctor" construct, I think it falls within the "Also, beware of writing if x when you really mean if x is not None -- e.g. when testing whether a variable or argument that defaults to None was set to some other value." recommendation of the PEP8 programming recommendations, so I think that it should rather be (in
self.ast_builder = ast_builder if ast_builer is not None else AstBuilder()
if token matcher is None: token_matcher = TokenMatcher()
Please change the pull request description to
Closes #335 etc, to take advantage of the automatic closing of issues when this pull request is merged.