New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-expressons: Escape generated expressions. Fix for #345 #346

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
1 participant
@aslakhellesoy
Contributor

aslakhellesoy commented Mar 24, 2018

This is a fix for #345.

  • Java
  • JavaScript
  • Ruby

Do not merge until all implementations are done.

cucumber-expressons: Escape generated expressions. Allow escaping {.
cucumber-expressions: Escape ( and { in generated expressions.

Add escapig to { as with (

@aslakhellesoy aslakhellesoy merged commit 7fdbea0 into master Apr 4, 2018

2 of 3 checks passed

ci/circleci No test commands were found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aslakhellesoy aslakhellesoy referenced this pull request Apr 4, 2018

Merged

cucumber-expressions: add go implementation #350

2 of 6 tasks complete

charlierudolph added a commit that referenced this pull request Apr 4, 2018

@aslakhellesoy aslakhellesoy deleted the cucumber-expressions-345-escape-generated-expressions branch Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment