Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-expressions: add go implementation #350

Merged
merged 32 commits into from Apr 5, 2018
Merged

cucumber-expressions: add go implementation #350

merged 32 commits into from Apr 5, 2018

Conversation

charlierudolph
Copy link
Member

Summary

Adds a go implementation for cucumber-expressions.

Details

Looked at the java / javascript / ruby implementations and ported to go.

Motivation and Context

I want this for building the shared binary and so the go version of cucumber can use them in the mean time

How Has This Been Tested?

I ported over all the tests from the javascript implementation (and some from other implementations that weren't in the javascript implementation). I'll try and make them consistent in another PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@aslakhellesoy
Copy link
Contributor

Excellent work @charlierudolph!!

Could you port #346 into this PR please? Then I'll merge it to master and also set up a read-only subrepo, and CI.

I'm on holiday and will be back in a week or so.

@aslakhellesoy aslakhellesoy merged commit 0457ad3 into master Apr 5, 2018
@aslakhellesoy
Copy link
Contributor

I've merged to master and set up a read-only subrepo mirror at https://github.com/cucumber/cucumber-expressions-go.

The Travis build is OK, except for Go 1.7: https://travis-ci.org/cucumber/cucumber-expressions-go/builds/362455501

I can't think of a good reason to support Go 1.7, so I'll just remove that requirement.

Exciting stuff indeed!

aslakhellesoy added a commit that referenced this pull request Apr 5, 2018
aslakhellesoy added a commit that referenced this pull request Apr 8, 2018
@aslakhellesoy aslakhellesoy deleted the cr-go2 branch July 12, 2018 21:14
@lock
Copy link

lock bot commented Jul 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants