New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for example value with $ #377

Merged
merged 4 commits into from May 18, 2018

Conversation

Projects
None yet
2 participants
@charlierudolph
Member

charlierudolph commented Apr 27, 2018

Summary

resolves #374

I'm uncertain if other languages require updates for this. I'll update them if the build fails.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
Charles Rudolph
@aslakhellesoy

LGTM!

@charlierudolph

This comment has been minimized.

Member

charlierudolph commented Apr 29, 2018

@aslakhellesoy It doesn't appear any of the new tests ran on CI. Does the rsync need to happen on this PR? I had put these in the gherkin/javascript/test-data folder initially to run the tests locally but moved them to top level.

@aslakhellesoy

This comment has been minimized.

Contributor

aslakhellesoy commented Apr 29, 2018

Oh I see. Sorry, should have checked that better. Merge with master, then try this:

# Sync testdata to all gherkin impls
source scripts/functions.sh && rsync_files

And then run the entire build on Docker:

./scripts/docker-run Dockerfile.cucumber-build make
@charlierudolph

This comment has been minimized.

Member

charlierudolph commented Apr 29, 2018

I wanted to sync the files in this PR, so I know if any other language needs fixes.

@aslakhellesoy

This comment has been minimized.

Contributor

aslakhellesoy commented Apr 29, 2018

I've got a fix incoming...

@aslakhellesoy

This comment has been minimized.

Contributor

aslakhellesoy commented Apr 29, 2018

Ok, so e482ef9 syncs your changes to all implementations. The build passed locally. If Travis is happy we can merge.

@aslakhellesoy aslakhellesoy merged commit e482ef9 into master May 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment