Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest .NET Core SDK in DotNet docker image #383

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
2 participants
@SabotageAndi
Copy link
Contributor

SabotageAndi commented May 7, 2018

Summary

Together with cucumber/gherkin-dotnet#15 it should fix the .NET build on the monorepo.
Only merge when cucumber/gherkin-dotnet#15 is pulled into monorepo.

Details

Use latest version of .NET Core SDK as of now (2.1.105)

Motivation and Context

To fix the build

How Has This Been Tested?

I run the tests locally in docker.
Docker image have to be regenerated and pushed to docker hub.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@SabotageAndi SabotageAndi referenced this pull request May 7, 2018

Merged

Fix CI builds #15

@aslakhellesoy aslakhellesoy merged commit dd93817 into cucumber:master May 7, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@aslakhellesoy

This comment has been minimized.

Copy link
Contributor

aslakhellesoy commented May 7, 2018

Hooray!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.