Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Java Gherkin parser. Rely on Go binary/protobuf #424

Merged
merged 7 commits into from Jul 3, 2018

Conversation

@aslakhellesoy
Copy link
Contributor

commented Jul 2, 2018

Summary

The Java Gherkin parser is gone!

Details

Parsing is delegated to a subprocess (gherkin-go executable)
The package has moved to io.cucumber.gherkin

Motivation and Context

Less code to maintain.

TODO

  • Package prebuilt go binaries for various platforms
  • Detect platform and extract the right binary
  • Detect more platforms - see protoc-jar
  • Download binary from S3 if not in jar
  • Set up build process

@aslakhellesoy aslakhellesoy changed the title Remove the Java Gherkin parser. Rely on Go binary/protobuf [WIP] Remove the Java Gherkin parser. Rely on Go binary/protobuf Jul 2, 2018

@aslakhellesoy

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2018

Currently, in order to build this, you have to:

cd gherkin/go
make cross-compile
cd ../java
mkdir gherkin-go && cp ../go/dist/*

We can automate that for the monorepo build, but for the subrepo build, ../go is not available. I think the best is to download the binaries from GitHub in that case. The publish-release target in gherkin/go can do the upload.

@aslakhellesoy aslakhellesoy referenced this pull request Jul 3, 2018
15 of 45 tasks complete

@aslakhellesoy aslakhellesoy changed the title [WIP] Remove the Java Gherkin parser. Rely on Go binary/protobuf Remove the Java Gherkin parser. Rely on Go binary/protobuf Jul 3, 2018

@aslakhellesoy aslakhellesoy merged commit ce718d9 into master Jul 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@mlvandijk

This comment has been minimized.

Copy link
Member

commented Jul 3, 2018

fyi, make cross-compile gave me an error; command 'gox' not recognized (or something similar).
Adding the following to my .bash_profile fixed it:

Add go bin to path

export PATH=$(go env GOPATH)/bin:${PATH}

@mlvandijk

This comment has been minimized.

Copy link
Member

commented Jul 3, 2018

Also cp ../go/dist/* ./gherkin-go to copy the files to the created dir

@aslakhellesoy

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2018

You shouldn't have to do that @mlvandijk - MagicFile will download from S3.

@aslakhellesoy aslakhellesoy deleted the gherkin-java-protobuf-only branch Jul 12, 2018

@lock

This comment has been minimized.

Copy link

commented Jul 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.