Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Java Gherkin parser. Rely on Go binary/protobuf #424

Merged
merged 7 commits into from Jul 3, 2018
Prev

gherkin: Add {{.Ext}}

  • Loading branch information...
aslakhellesoy committed Jul 3, 2018
commit 53838598cfa79a81223ced0199aed94d42c980c8
@@ -65,7 +65,7 @@ public void extracts_file_from_file_system() {

@Test
public void downloads_file_from_s3() {
MagicFile magicFile = new MagicFile("gherkin-{{.OS}}-{{.Arch}}", new HashMap<Object, Object>() {{
MagicFile magicFile = new MagicFile("gherkin-{{.OS}}-{{.Arch}}{{.Ext}}", new HashMap<Object, Object>() {{
put("os.name", "Mac OS X");
put("os.arch", "x86_64");
}});
@@ -79,7 +79,7 @@ public void downloads_file_from_s3() {
@Test
public void throws_exception_with_explanation_when_file_not_found() {
expected.expectMessage("Failed to download https://s3.eu-west-2.amazonaws.com/io.cucumber/gherkin-go/master/notfound-darwin-amd64");
MagicFile magicFile = new MagicFile("notfound-{{.OS}}-{{.Arch}}", new HashMap<Object, Object>() {{
MagicFile magicFile = new MagicFile("notfound-{{.OS}}-{{.Arch}}{{.Ext}}", new HashMap<Object, Object>() {{
put("os.name", "Mac OS X");
put("os.arch", "x86_64");
}});
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.