Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin-perl: Add Perl infrastructure to the CI docker images #695

Merged
merged 1 commit into from Sep 25, 2019

Conversation

ehuelsmann
Copy link
Contributor

Summary

Add Perl infrastructure required to start testing Perl implementation.

Details

Before this change, there's insufficient Perl in the images
(none, actually) to run the Perl tests and thus to verify
validity of PR #694.

Incidentally add --notest flag to cpanm to stop it from
downloading half of CPAN in order to test dependencies it's
building.

How Has This Been Tested?

In my local Docker environment I verified that this change is enough to run Perl and install dependencies using the module installer cpanm on which the gherkin-perl Makefile depends.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

None of the above are applicable.

Before this change, there's insufficient Perl in the images
(none, actually) to run the Perl tests and thus to verify
validity of PR cucumber#694.

Incidentally add `--notest` flag to cpanm to stop it from
downloading half of CPAN in order to test *dependencies* it's
building.
@aslakhellesoy
Copy link
Contributor

aslakhellesoy commented Sep 4, 2019

Great work @ehuelsmann! I'd like to improve the CI build so that new docker images are published automatically. Currently I have to push them manually, and that makes it tedious for me everyone to work with pull requests to the docker image.

I'll add this onto this branch and test it out. Then I'll merge this.

Aslak

@aslakhellesoy aslakhellesoy merged commit cc98c10 into cucumber:master Sep 25, 2019
@aslakhellesoy
Copy link
Contributor

Hi @ehuelsmann,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants