New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed default link & added appropriate links to resources #144 #242

Merged
merged 3 commits into from Nov 4, 2018

Conversation

Projects
None yet
3 participants
@sridhareaswaran
Contributor

sridhareaswaran commented Oct 11, 2018

Worked on:
Issue #144 - Close down / archive / redirect old doc

Changes:

  1. Removed default URL in card.html
  2. Added appropriate URLs to resources listed in books.md
@mlvandijk

mlvandijk requested changes Oct 12, 2018 edited

Thank you for offering improvements! Just a question for the Cucumber people regarding where to link from the books (see below) and a request to move the tool to a different tools-page.

Also, I'm not sure how this is related to #144 which is about cleaning up the old links from the wiki..

@@ -25,6 +25,10 @@ It offers several [packages](https://atom.io/packages/search?q=cucumber) you can
[TextMate](https://macromates.com/) is a text editor for macOS.
See the [`Cucumber.tmbundle`](https://github.com/cucumber/cucumber-tmbundle) documentation.
## Tidy Gherkin

This comment has been minimized.

@mlvandijk

mlvandijk Oct 12, 2018

Member

This tool should be on the Related Tools page instead of the general tools page. Could you move it there please?

This comment has been minimized.

@sridhareaswaran

sridhareaswaran Oct 12, 2018

Contributor

Sure, I will move that.

@@ -1,4 +1,4 @@
<a href="http://google.com">
<a href="{{ .Get "link" }}">
<div class="card" style="height: 100%">

This comment has been minimized.

@mlvandijk

mlvandijk Oct 12, 2018

Member

Going to a specific link per book instead of Google home page is a great idea. Just not sure about what the particular links should be

@@ -11,23 +11,26 @@ We like these Books
<div class="column is-one-third">
{{% card
title="Discovery"
image="/img/book-discovery.png"
image="/img/book-discovery.png"
link="https://www.goodreads.com/book/show/36126762-the-bdd-books"

This comment has been minimized.

@mlvandijk

mlvandijk Oct 12, 2018

Member

I like having individual links per book, rather than go to google home page. Not sure it should go to GoodReads though. @aslakhellesoy @mattwynne @sebrose - do you have an opinion on this?

This comment has been minimized.

@sridhareaswaran

sridhareaswaran Oct 12, 2018

Contributor

Ya, I felt the same. But then the reason for choosing GoodReads is that it provides genuine user reviews, multiple vendors and formats (Physical, digital & audio) for the user to choose from. Let's hear from others too.

This comment has been minimized.

@mattwynne

mattwynne Nov 7, 2018

Member

From an author's point of view, linking to the Pragmatic Programmers' page for the books that are published through them means we get a better royalty payment than if you link to Amazon. Otherwise, just do what seems most useful to the reader.

@mlvandijk mlvandijk requested review from aslakhellesoy and mattwynne Oct 25, 2018

@mlvandijk mlvandijk merged commit 6834049 into cucumber:master Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment