Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gherkin language execution parameters #412

Closed
wants to merge 1 commit into from
Closed

Fix Gherkin language execution parameters #412

wants to merge 1 commit into from

Conversation

brazilianbytes
Copy link

Cucumber 6.0.3 parameters are different from documentation.


To see a listing of available languages:
```shell
cucumber --i18n help
cucumber --i18n-languages help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this option is named differently across platforms, so changing from --i18n to --i18n-languages makes this incorrect for cucumber-ruby and cucumber-jvm.

I think we should simply get rid of the option and refer users to the docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aslakhellesoy
Copy link
Contributor

Should we just close this, or do we want to make the docs language specific? WDYT @mlvandijk ?

@mlvandijk
Copy link
Member

mlvandijk commented Nov 1, 2019

@aslakhellesoy We don't currently have different language tabs on the Gherkin page(s) as Gherkin should be programming language agnostic.

We could just remove this section imho. - what do you think?

@mlvandijk
Copy link
Member

Thanks for pointing out the inconsistency though @brazilianbytes!

@aslakhellesoy
Copy link
Contributor

There are two suggestions here:

  1. Remove the docs about --i18n
  2. Remove --i18n from Cucumbers - see https://github.com/cucumber/cucumber/issues/783

I think we should remove both.

@mlvandijk
Copy link
Member

@aslakhellesoy Can we point them anywhere to see up to date available languages (rather than duplicate in documentation?). Kind of like we do for DataTables (points to datatable README from the docs)

@aslakhellesoy
Copy link
Contributor

@mlvandijk
Copy link
Member

Perfect! Let's link there. @brazilianbytes - would you be willing to do this change instead?

@mlvandijk
Copy link
Member

Closed in favor of cucumber/common#431

@mlvandijk mlvandijk closed this Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants