Skip to content

[cpp] Fix regenerating dialect.cpp, and do so #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented Jun 17, 2025

🤔 What's changed?

I therefore adjusted the template in dialect.cpp.jq to match the #include and namespace we already have in dialect.cpp, then re-generated dialect.cpp, which incidentally brought in a couple of new translations.

⚡️ What's your motivation?

While investigating #414 (comment), I found that the #include path and namespace had changed in dialect.cpp, but the dialect.cpp.jq from which it is generated had not been updated to match.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje mpkorstanje merged commit 7c28f20 into cucumber:main Jun 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants