[c] Prefer the longest step keyword #417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
In C, prefer the longest step keyword by iterating all keywords and continuing to match against keywords that are longer than the longest keyword matched so far. This is equivalent to sorting in descending order by length in bytes before matching as in #416, but does not require creating and sorting a temporary copy of the keywords array.
⚡️ What's your motivation?
Fixes #400 for C.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Mostly skim for obvious oversights, particularly those that might be due to my relative unfamiliarity with gherkin.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.
Before this PR:
After this PR:
I think I can propose a separate fix for the remaining error.