Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

368 public formatter #372

Merged
merged 17 commits into from Aug 10, 2021
Merged

368 public formatter #372

merged 17 commits into from Aug 10, 2021

Conversation

leviable
Copy link
Member

@leviable leviable commented Jan 27, 2021

Closes #368

This PR exposes Godog formatters, making them embeddable by custom formatters

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

 - Working example where the custom formatter is built on top of
   the Progress formatter, using emojis instead of text
@leviable
Copy link
Member Author

leviable commented Feb 8, 2021

If this is a non-starter, please let me know :)

@inluxc
Copy link

inluxc commented May 19, 2021

Is this issue still in progress?

@mattwynne
Copy link
Member

Hi,

I'm one of the Cucumber org's maintainers. We're short on regular maintainers for godog at the moment so sorry for the delay getting this reviewed. I'm happy to merge this if someone can rebase it.

@inluxc
Copy link

inluxc commented Jul 20, 2021

I will give it a try and test with one of my own formatters

fulviocarvalhido and others added 8 commits July 22, 2021 12:48
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #372 (c6210f7) into main (ad7feb3) will decrease coverage by 0.38%.
The diff coverage is 90.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   83.07%   82.69%   -0.39%     
==========================================
  Files          26       26              
  Lines        2511     2525      +14     
==========================================
+ Hits         2086     2088       +2     
- Misses        328      340      +12     
  Partials       97       97              
Impacted Files Coverage Δ
fmt.go 63.63% <0.00%> (-36.37%) ⬇️
internal/formatters/fmt_progress.go 94.04% <90.24%> (+0.14%) ⬆️
internal/formatters/fmt_base.go 86.33% <95.83%> (ø)
internal/formatters/fmt_pretty.go 80.74% <96.77%> (ø)
internal/formatters/fmt_events.go 97.48% <98.03%> (ø)
internal/formatters/fmt_cucumber.go 85.03% <100.00%> (ø)
internal/formatters/fmt_junit.go 95.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7feb3...c6210f7. Read the comment docs.

@inluxc inluxc changed the title WIP: 368 public formatter 368 public formatter Jul 28, 2021
@inluxc inluxc marked this pull request as draft July 28, 2021 13:43
@inluxc inluxc added this to the v0.12.0 milestone Jul 28, 2021
@inluxc inluxc requested a review from vearutop August 9, 2021 14:11
@inluxc inluxc marked this pull request as ready for review August 9, 2021 16:57
Copy link
Member

@vearutop vearutop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expressed my review suggestions as #418, please check if they make sense to be applied here.

@vearutop vearutop merged commit c6c2a08 into main Aug 10, 2021
@vearutop vearutop deleted the 368-public-formatter branch August 10, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Base Formatter public and/or accessible by custom formatters
4 participants