From 191f8a85de65069ed02e63c4549f23e70350d1f8 Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 19 Nov 2025 07:07:09 +0000 Subject: [PATCH 1/5] bump messages --- package-lock.json | 19 +++++++++++++++---- package.json | 2 +- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index ea26523..3431b5a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,7 @@ "devDependencies": { "@cucumber/cucumber-expressions": "^18.0.1", "@cucumber/gherkin": "^36.0.0", - "@cucumber/messages": "^30.0.0", + "@cucumber/messages": "^31.0.0", "@cucumber/query": "^14.0.0", "@cucumber/tag-expressions": "^8.0.0", "@eslint/js": "^9.31.0", @@ -85,10 +85,21 @@ "@cucumber/messages": ">=19.1.4 <31" } }, + "node_modules/@cucumber/gherkin/node_modules/@cucumber/messages": { + "version": "30.1.0", + "resolved": "https://registry.npmjs.org/@cucumber/messages/-/messages-30.1.0.tgz", + "integrity": "sha512-KxnsSjHz9EGF23GeZc3BRMK2+bagt2p87mwwNfisBK7BfuyvnXJumyBQJJN4xv5SLSzBKxH3FsZnuOf8LwsHhg==", + "dev": true, + "license": "MIT", + "dependencies": { + "class-transformer": "0.5.1", + "reflect-metadata": "0.2.2" + } + }, "node_modules/@cucumber/messages": { - "version": "30.0.0", - "resolved": "https://registry.npmjs.org/@cucumber/messages/-/messages-30.0.0.tgz", - "integrity": "sha512-Q49dy57Iv58sTU4z3I9FU0mfCOk/6akuqiANr99eWzX2hBuywbsrGSwi6nEAisLJwiKvSK/kKxlo/YQPegjkEA==", + "version": "31.0.0", + "resolved": "https://registry.npmjs.org/@cucumber/messages/-/messages-31.0.0.tgz", + "integrity": "sha512-Dqhatp4AjMsH9SREfWz3Q8nlGuwJMTW7YAW5L3OzRId86ZUEu/a8vIL1RO2c0agQefuBS2SVH9fEZ66ovrMYRA==", "dev": true, "license": "MIT", "peer": true, diff --git a/package.json b/package.json index 2c5aec6..6b26ef6 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "devDependencies": { "@cucumber/cucumber-expressions": "^18.0.1", "@cucumber/gherkin": "^36.0.0", - "@cucumber/messages": "^30.0.0", + "@cucumber/messages": "^31.0.0", "@cucumber/query": "^14.0.0", "@cucumber/tag-expressions": "^8.0.0", "@eslint/js": "^9.31.0", From aa02ae94070da31650d74e6ab1d128e4a11d4cc8 Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 19 Nov 2025 19:09:32 +0000 Subject: [PATCH 2/5] bump gherkin --- package-lock.json | 21 +++++---------------- package.json | 2 +- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3431b5a..86acfae 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10,7 +10,7 @@ "license": "MIT", "devDependencies": { "@cucumber/cucumber-expressions": "^18.0.1", - "@cucumber/gherkin": "^36.0.0", + "@cucumber/gherkin": "^37.0.0", "@cucumber/messages": "^31.0.0", "@cucumber/query": "^14.0.0", "@cucumber/tag-expressions": "^8.0.0", @@ -76,24 +76,13 @@ } }, "node_modules/@cucumber/gherkin": { - "version": "36.0.0", - "resolved": "https://registry.npmjs.org/@cucumber/gherkin/-/gherkin-36.0.0.tgz", - "integrity": "sha512-L/WomevUuGSHWeJqLN9yEsz37ns0M1BiRu8Isp+hlYTBAYzt6ZkLiUEK3W9gT5STu++lL/2tE04bD8Ma1p0AYw==", + "version": "37.0.0", + "resolved": "https://registry.npmjs.org/@cucumber/gherkin/-/gherkin-37.0.0.tgz", + "integrity": "sha512-vKJVJ6h4HCktG870wgYUUskNpFxbFI0WmAkVLPTz1LlLwJX7/KOBqFcr2/L3u0pPoHjbLRW+IpbiXLT2T13/wg==", "dev": true, "license": "MIT", "dependencies": { - "@cucumber/messages": ">=19.1.4 <31" - } - }, - "node_modules/@cucumber/gherkin/node_modules/@cucumber/messages": { - "version": "30.1.0", - "resolved": "https://registry.npmjs.org/@cucumber/messages/-/messages-30.1.0.tgz", - "integrity": "sha512-KxnsSjHz9EGF23GeZc3BRMK2+bagt2p87mwwNfisBK7BfuyvnXJumyBQJJN4xv5SLSzBKxH3FsZnuOf8LwsHhg==", - "dev": true, - "license": "MIT", - "dependencies": { - "class-transformer": "0.5.1", - "reflect-metadata": "0.2.2" + "@cucumber/messages": ">=31.0.0 <32" } }, "node_modules/@cucumber/messages": { diff --git a/package.json b/package.json index 6b26ef6..aa04bba 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ }, "devDependencies": { "@cucumber/cucumber-expressions": "^18.0.1", - "@cucumber/gherkin": "^36.0.0", + "@cucumber/gherkin": "^37.0.0", "@cucumber/messages": "^31.0.0", "@cucumber/query": "^14.0.0", "@cucumber/tag-expressions": "^8.0.0", From 287fb2f3425e8f54a847fd80ac91e6f1f80ad461 Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 19 Nov 2025 19:17:53 +0000 Subject: [PATCH 3/5] get location directly from pickle --- src/makeTestPlan.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/makeTestPlan.ts b/src/makeTestPlan.ts index 5089405..3eea244 100644 --- a/src/makeTestPlan.ts +++ b/src/makeTestPlan.ts @@ -49,7 +49,7 @@ export function makeTestPlan( name: gherkinDocument.feature?.name || gherkinDocument.uri, testCases: pickles.map((pickle) => { const lineage = query.findLineageBy(pickle) as Lineage - const location = query.findLocationOf(pickle) as MessagesLocation + const location = pickle.location as MessagesLocation return { id: newId(), pickleId: pickle.id, From c774a6387eab2f2c26a5cd734722bb08b7ed92e2 Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 19 Nov 2025 19:28:26 +0000 Subject: [PATCH 4/5] set messages version requirement --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 86acfae..7fd8e9a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -37,7 +37,7 @@ }, "peerDependencies": { "@cucumber/cucumber-expressions": "*", - "@cucumber/messages": "*", + "@cucumber/messages": ">=31.0.0", "@cucumber/query": "*", "@cucumber/tag-expressions": "*" } diff --git a/package.json b/package.json index aa04bba..028e9c3 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "homepage": "https://github.com/cucumber/javascript-core#readme", "peerDependencies": { "@cucumber/cucumber-expressions": "*", - "@cucumber/messages": "*", + "@cucumber/messages": ">=31.0.0", "@cucumber/query": "*", "@cucumber/tag-expressions": "*" }, From ca1d7f90bcc6dec0d13c07d5375071268a006bc3 Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 19 Nov 2025 19:32:14 +0000 Subject: [PATCH 5/5] update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b4738a..95d99ca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Changed +- Require messages v31 or greater ([#30](https://github.com/cucumber/javascript-core/pull/30)) ## [0.6.0] - 2025-11-17 ### Added