Skip to content

Conversation

@dermetfan
Copy link
Contributor

Issue reference:

In response to #74 (comment).

I hope the wording is okay.

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

@dermetfan dermetfan changed the title update changelog with note about breaking change in #74 update changelog with note about breaking change to fix #75 Jul 15, 2024
@kvanbere
Copy link
Member

kvanbere commented Aug 6, 2024

Thank you @dermetfan, sorry for the delay.

@kvanbere
Copy link
Member

kvanbere commented Aug 6, 2024

Would you like to be added to the AUTHORS file?

@kvanbere kvanbere changed the title update changelog with note about breaking change to fix #75 [#75]: Update changelog with note about change to fix Aug 6, 2024
@dermetfan dermetfan deleted the pr-draft branch August 17, 2024 20:09
@dermetfan
Copy link
Contributor Author

Feel free to add me if you think my tiny contribution justifies it :)

ashercuedo added a commit that referenced this pull request Mar 25, 2025
This reverts commit e10f0e9 as the merged pull request was a mistake.
ashercuedo added a commit that referenced this pull request Mar 25, 2025
* Added 'workflow_dispatch' to allow them to be triggered.

- Github Workflows couldn't be triggered because they were missing the line 'workflow_dispatch' under 'on'

Committer: AsherCuedo <asher.olorenshaw@cuedo.com.au>

On branch 79-workflows-not-triggering
Changes to be committed:
	modified:   scan-code.yml
	modified:   test-macos-latest.yml
	modified:   test-ubuntu-latest.yml
	modified:   test-windows-latest.yml

* Revert "[#75]: Update changelog with note about change (#76)"

This reverts commit e10f0e9 as the merged pull request was a mistake.

* Minor syntax tweaks

* Reverted a mistake that happened (accidentally removed a line from CHANGELOG.md)

* Updated to GitHub actions v4

* Updated additional missing action dependencies to v4

* Updated scan-code to Github actions v4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants