Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

check for var type on fixAndPushPaths to avoid safari 6 strictness #109

Closed
wants to merge 1 commit into from

2 participants

Tiago Rodrigues John Hann
Tiago Rodrigues

While testing stuff on Safari 6, we've found out that it is a bit more strict and it doesn't like if you try to assign a property to a string, while other browsers seem to fail silently.

John Hann

Hey Tiago! Thanks for finding this! I'm actually refactoring that config mess atm, so I fixed the problem by removing "use strict". New release (0.6.6) coming in minutes. -- J

John Hann

Closure-compiled versions are unaffected, btw, since Closure removes "use strict".

Tiago Rodrigues

Oh great stuff :) I'll try and build a new version later on and provide some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 23, 2012
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +3 −1 src/curl.js
4 src/curl.js
View
@@ -430,7 +430,9 @@ var window;
data = coll[name];
// grab the package id, if specified. default to
// property name.
- data.name = data['id'] || data['name'] || name;
+ if(typeof(data) == 'object'){
+ data.name = data['id'] || data['name'] || name;
+ }
currCfg = newCfg;
// don't remove `|| name` since data may be a string, not an object
parts = pluginParts(removeEndSlash(data.name || name));
Something went wrong with that request. Please try again.