Skip to content

Update map() to propagate notification/progress events #125

Merged
merged 1 commit into from Mar 7, 2013

2 participants

@depeele
depeele commented Mar 6, 2013

I noticed that When.all() doesn't propagate notification/progress events and was able to track it down to an omission in When.map().

Thanks for the wonderful library!

@briancavalier
The Javascript Architectural Toolkit member

Hey @depeele, nice catch, thanks! I'd be interested to hear how you are using progress events with when.all()? Do you have a simple example you can share?

@briancavalier briancavalier merged commit 64a37e0 into cujojs:master Mar 7, 2013

1 check passed

Details default The Travis build passed
@depeele
depeele commented Mar 7, 2013

I can't really discuss specifics, but in general, I have a system comprised of a number of backend asynchronous parts that are controlled by and feed into a user interface. During the asynchronous operations, the user interface needs to be able to keep the user updated on what exactly is happening and it's general progress.

I've created a small example gist that I used to track down this issue.

@briancavalier
The Javascript Architectural Toolkit member

Cool, that sounds like a really interesting system. I'm always looking to learn about how people are using progress events, since I tend not to use them very much. Yours sounds like a perfect use case for them. Thanks for sharing the gist link, and for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.