Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed behavior in browser when used with mocha.js version 1.9.0 #136

Merged
merged 1 commit into from Apr 5, 2013

Conversation

Projects
None yet
3 participants

Narsul commented Apr 5, 2013

There is a problem with defining nextTick function when you use when.js in browser together with Mocha.js 1.9.0

I've just added additional check for existence of method nextTick in process object.
If doesn't change any logic, but fixes the problem.

Owner

briancavalier commented Apr 5, 2013

Ugh, mocha defines a global process function. Bummer. Thanks for the PR, I'll take a look later today.

briancavalier added a commit that referenced this pull request Apr 5, 2013

Merge pull request #136 from Narsul/master
Fixed behavior in browser when used with mocha.js version 1.9.0

@briancavalier briancavalier merged commit bc5c7e7 into cujojs:master Apr 5, 2013

1 check failed

default The Travis build could not complete due to an error
Details

Narsul commented Apr 5, 2013

Thank you for the quick response!

Owner

unscriptable commented Apr 5, 2013

Seems like a safer check, anyways. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment