Allow developers to use the tabstop they prefer #74

Merged
merged 1 commit into from Nov 21, 2012

Conversation

Projects
None yet
2 participants
Contributor

renato-zannon commented Nov 21, 2012

Because indent_style is set to tab, it doesn't really matter which is the tabstop on each editor. The contents of the files will remain the same, regardless of how much horizontal space each developer likes :)

From http://editorconfig.org/#supported-properties

when indent_style is set to tab it may be desireable to leave indent_size unspecified so readers may view the file using their prefered indentation format.

@briancavalier briancavalier added a commit that referenced this pull request Nov 21, 2012

@briancavalier briancavalier Merge pull request #74 from riccieri/editorconfig
Allow developers to use the tabstop they prefer
a2bc6d3

@briancavalier briancavalier merged commit a2bc6d3 into cujojs:master Nov 21, 2012

1 check passed

default The Travis build passed
Details
Owner

briancavalier commented Nov 21, 2012

cool, thanks! Just a quick note for future pull requests: please target the dev branch rather than master. I wish github had a way to set that :/

Contributor

renato-zannon commented Nov 21, 2012

Oh, okay! Sorry for that.
Maybe a note about that should go at the bottom of the README, or at a CONTRIBUTING file :)

Owner

briancavalier commented Nov 21, 2012

No worries. That's a great suggestion. I'll add it :)

Brian

On Nov 21, 2012, at 5:57 AM, Renato Riccieri Santos Zannon <
notifications@github.com> wrote:

Oh, okay! Sorry for that.
Maybe a note about that should go at the bottom of the README, or at a
CONTRIBUTING file :)


Reply to this email directly or view it on
GitHubhttps://github.com/cujojs/when/pull/74#issuecomment-10592810.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment