Should aop section link to https://github.com/cujojs/meld ? #114

Closed
skiadas opened this Issue Jun 17, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@skiadas
Contributor

skiadas commented Jun 17, 2013

The docs section on aop: docs/connections.md#aspect-oriented-programming-aop
has a fair number of examples, but for instance does not discuss 'around' advices. Would it make sense for that section to link to cujojs/meld, just as the "promise-aware aop" section links to cujojs/when ?

@briancavalier

This comment has been minimized.

Show comment Hide comment
@briancavalier

briancavalier Jun 18, 2013

Member

Yeah, I think it's mostly a deficiency in the wire docs--we def need to add a section on around advice. As for linking to meld, we should probably do that, too. In some sense, though, meld is simply an implementation detail of wire's AOP.

Sounds like there are two action items here:

  1. Add docs and examples for wire's around advice.
  2. Add a link to meld, even if only for more background reading on AOP concepts, and halo effect.
Member

briancavalier commented Jun 18, 2013

Yeah, I think it's mostly a deficiency in the wire docs--we def need to add a section on around advice. As for linking to meld, we should probably do that, too. In some sense, though, meld is simply an implementation detail of wire's AOP.

Sounds like there are two action items here:

  1. Add docs and examples for wire's around advice.
  2. Add a link to meld, even if only for more background reading on AOP concepts, and halo effect.

@ghost ghost assigned briancavalier Jun 18, 2013

@skiadas

This comment has been minimized.

Show comment Hide comment
@skiadas

skiadas Jun 20, 2013

Contributor

Hm I need to figure out how to make the pull request automatically link to an issue. Anyway, #115
Not sure the language is quite right.

Contributor

skiadas commented Jun 20, 2013

Hm I need to figure out how to make the pull request automatically link to an issue. Anyway, #115
Not sure the language is quite right.

@briancavalier

This comment has been minimized.

Show comment Hide comment
@briancavalier

briancavalier Jun 20, 2013

Member

Thanks!

FYI: To autolink, just mention the issue number in the description body (not the title) of the PR.

Member

briancavalier commented Jun 20, 2013

Thanks!

FYI: To autolink, just mention the issue number in the description body (not the title) of the PR.

@skiadas

This comment has been minimized.

Show comment Hide comment
@skiadas

skiadas Jun 20, 2013

Contributor

Gotcha

Contributor

skiadas commented Jun 20, 2013

Gotcha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment