Fix some of the resolver.reject's to return Error objects #118

merged 1 commit into from Jul 4, 2013

2 participants


There are two more rejects that I did not dare touch, as they seemed to return some objects of unspecified form instead of strings. Namely:

Line 36 in lib/ComponentFactory.js


Line 72 in lib/lifecycle.js

There are also some uses of "sentinel" as a reject reason in test/node/aop-test.js but since it's in the test it might not matter all that much.


Hm, I forgot to reference #117

The Javascript Architectural Toolkit member

Looks great, thanks!

@briancavalier briancavalier merged commit 006ea8c into cujojs:dev Jul 4, 2013
The Javascript Architectural Toolkit member

Yeah, the one in ComponentFactory is there for a specific reason and is never exposed to callers, and the sentinel values in the tests are specifically used for testing purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment