fix: small QOL changes #32
Conversation
This has the side effect of defining the update flag to the test package. Without this, using the -update flag to update golden files in the other packages causes a non-fatal error to be printed.
Makes it easier to test the rest of the plugin locally.
This will make it slightly quicker to receive and parse (as it's then thrown away).
Clarifies that the plugin will only fail a step if finding thresholds are specified. There was some confusion around the placement of ignore configuration. I've tried to make this more clear by rewording the README and rewriting much of the ignore documentation.
| @@ -5,6 +5,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/cultureamp/ecrscanresults/findingconfig" | |||
| _ "github.com/hexops/autogold/v2" | |||
There was a problem hiding this comment.
That's pretty whack (why you have to include this in the first place), I had a quick browse of the repo and I didn't immediately find an issue relating to this. Is there an issue you found where this was the suggestion?
There was a problem hiding this comment.
No, I had to work it out
There was a problem hiding this comment.
The underlying issue seemed to stem from this change: hexops/autogold#45, but I'm not 100% sure.
The Go test tool doesn't like it when a flag is present but not consumed by code, and writes a long message to that effect. However, since go test generates a main function to run tests, and doesn't load _test files from other packages, if the autogold package isn't referenced by the package itself, the flag isn't consumed.
So when you run go test ./... -update and it iterates over all the packages, some of them write a failure about the unused flag, because they're not using "golden" files.
There was a problem hiding this comment.
Sorry for the short reply earlier.
This PR has 4 small changes:
autogoldis imported in packages where it's not used, so the-updateflag doesn't cause spurious errors.ECRSCANRESULTS_DISABLE_AGENT