Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to mention the right AWS env vars #3

Merged
merged 1 commit into from
May 3, 2018
Merged

Update README to mention the right AWS env vars #3

merged 1 commit into from
May 3, 2018

Conversation

vgunawan
Copy link
Contributor

Seems Go AWS SDK reads region information from AWS_REGION env vars instead of AWS_DEFAULT_REGION.

@pda
Copy link
Contributor

pda commented Dec 17, 2017

Interesting, it was working for me using AWS_DEFAULT_REGION. I'll see if I can investigate further.

@vgunawan
Copy link
Contributor Author

vgunawan commented Jan 1, 2018

I have to use AWS_REGION in comments reporting service to make it work.

mrck
mrck approved these changes May 3, 2018
View reviewed changes
Copy link

@mrck mrck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pda This seems to solve the problem for me as well, should prevent #2 from happening.

@pda pda merged commit bca4059 into cultureamp:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrck mrck mrck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgunawan @pda @mrck