From afb811099a5af9d1d0ef3243f30929a147ad21db Mon Sep 17 00:00:00 2001 From: Wouter Vanelslander Date: Wed, 3 Oct 2018 14:33:15 +0200 Subject: [PATCH 1/3] feature/WKS-367: Parse the "externalid" page property --- lib/CultureFeed/Cdb/Item/Page.php | 33 ++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/lib/CultureFeed/Cdb/Item/Page.php b/lib/CultureFeed/Cdb/Item/Page.php index 7b04fc4..a95d692 100644 --- a/lib/CultureFeed/Cdb/Item/Page.php +++ b/lib/CultureFeed/Cdb/Item/Page.php @@ -97,6 +97,14 @@ class CultureFeed_Cdb_Item_Page implements CultureFeed_Cdb_IElement protected $tagline; /** + * The external Id of the page. + * + * @var string + */ + protected $externalId; + + + /** * Get the id of this page. * @return string */ @@ -386,7 +394,27 @@ public function setTagline($tagline) $this->tagline = $tagline; } + + /** + * Set the external id of this page. + * @param string $externalId + */ + public function setExternalId($externalId) + { + $this->externalId = $externalId; + } + /** + * Get the external id of this page. + * @return string + */ + public function getExternalId() + { + return $this->externalId; + } + + + /** * @see CultureFeed_Cdb_IElement::appendToDOM() */ public function appendToDOM(DOMElement $element) @@ -545,6 +573,9 @@ public static function parseFromCdbXml(SimpleXMLElement $xmlElement) // Set tagline. $page->setTagline((string) $xmlElement->tagline); - return $page; + // Set external id. + $page->setExternalId((string) $xmlElement->externalid); + + return $page; } } From d74343df5d86c1295a03d444d2b991f0e639bfd4 Mon Sep 17 00:00:00 2001 From: Wouter Vanelslander Date: Wed, 3 Oct 2018 14:40:43 +0200 Subject: [PATCH 2/3] feature/WKS-367: Coding standards --- lib/CultureFeed/Cdb/Item/Page.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/CultureFeed/Cdb/Item/Page.php b/lib/CultureFeed/Cdb/Item/Page.php index a95d692..ae997e7 100644 --- a/lib/CultureFeed/Cdb/Item/Page.php +++ b/lib/CultureFeed/Cdb/Item/Page.php @@ -401,7 +401,7 @@ public function setTagline($tagline) */ public function setExternalId($externalId) { - $this->externalId = $externalId; + $this->externalId = $externalId; } /** @@ -410,7 +410,7 @@ public function setExternalId($externalId) */ public function getExternalId() { - return $this->externalId; + return $this->externalId; } @@ -576,6 +576,6 @@ public static function parseFromCdbXml(SimpleXMLElement $xmlElement) // Set external id. $page->setExternalId((string) $xmlElement->externalid); - return $page; + return $page; } } From 59123430346a1d8ac26415f31670f283424f412e Mon Sep 17 00:00:00 2001 From: Wouter Vanelslander Date: Wed, 3 Oct 2018 14:47:44 +0200 Subject: [PATCH 3/3] feature/WKS-367: Removed testing for PHP 5.5, 5.4 & 5.3 --- .travis.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index dfbfd79..b234ab7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,9 +1,6 @@ language: php php: - 5.6 - - 5.5 - - 5.4 - - 5.3 install: composer install script: ./vendor/bin/phing test after_success: ./vendor/bin/phing report-to-coveralls