New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP7 Compatibility Issues #253
Comments
Thanks, @r-a-y. I've fixed three of the four errors. The third one will be harder:
I think that fixing this will require rewriting as |
Thanks for looking into this, @boonebgorges. I think the |
In case anyone ever wants to verify 6b98ee3, here were my two testcases: require_once 'wp-content/themes/cbox-theme/engine/ICE/lib/textile/classTextile.php';
$t = new Textile();
$text = 'footnote foo[10] bar';
$found = $t->footnoteRef( $text );
var_Dump( $found );
$text = 'footnote foo[10!] bar';
$found = $t->footnoteRef( $text );
var_Dump( $found ); |
I've reviewed the warnings and I think we can probably safely avoid them. They're all related to reference-vs-value issues, and while there's no way I can audit the whole codebase to ensure that we're not modifying items that are being returned by reference, the risk in these specific cases seems pretty low when compared to the amount of refactoring that'd have to take place to remove them. Going to close as fixed. |
As raised on the cbox.org forums, there are some PHP7 compatibility issues.
I've run cbox-theme through php7cc (stable version) and these are the errors that need to be fixed up:
Warnings:
The text was updated successfully, but these errors were encountered: