Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `cupy.linalg.matrix_power` #1374

Merged
merged 3 commits into from Jun 19, 2018

Conversation

Projects
None yet
3 participants
@ericmjl
Copy link
Contributor

ericmjl commented Jun 16, 2018

cc: @asi1024 and @kmaehashi, thank you for all the help put in so far. I am really sorry that I have had to redo this a few times.

To prep for this PR, I deleted my CuPy fork, re-forked CuPy, and applied the patch from the v2 PR (#1371) as a single commit. This PR closes #1358.

@ericmjl

This comment has been minimized.

Copy link
Contributor Author

ericmjl commented Jun 16, 2018

Not sure if this command works (coming from me), but I'll try it anyways.

Jenkins, test this please.

@kmaehashi

This comment has been minimized.

Copy link
Member

kmaehashi commented Jun 18, 2018

Thank you for your work! LGTM.

Jenkins, test this please.
(sorry, this command only work for CuPy maintainers)

@kmaehashi kmaehashi added this to the v5.0.0b2 milestone Jun 18, 2018

@kmaehashi kmaehashi self-assigned this Jun 18, 2018

@kmaehashi

This comment has been minimized.

Copy link
Member

kmaehashi commented Jun 18, 2018

Please merge ericmjl#1 for CUDA 7.x support.

@chainer-ci

This comment has been minimized.

Copy link

chainer-ci commented Jun 18, 2018

Jenkins CI test (for commit f644951) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@ericmjl

This comment has been minimized.

Copy link
Contributor Author

ericmjl commented Jun 18, 2018

@kmaehashi @asi1024 thank you both for all the help! I will leave the PR in your hands now. Do let me know if there's something more I can do!

Merge pull request #1 from kmaehashi/pull-1374-cuda8
matrix_power: Fix for CUDA 7.x support
@kmaehashi

This comment has been minimized.

Copy link
Member

kmaehashi commented Jun 18, 2018

@ericmjl Thanks! I'll merge after Jenkins test pass.

Jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link

chainer-ci commented Jun 18, 2018

Jenkins CI test (for commit 3b48a94) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@kmaehashi

This comment has been minimized.

Copy link
Member

kmaehashi commented Jun 18, 2018

Jenkins, test this please.

@chainer-ci

This comment has been minimized.

Copy link

chainer-ci commented Jun 18, 2018

Jenkins CI test (for commit 3b48a94) succeeded without errors!

@kmaehashi kmaehashi merged commit c3dc0ce into cupy:master Jun 19, 2018

3 checks passed

codecov/patch 91.66% of diff hit (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 92.574%
Details
@kmaehashi

This comment has been minimized.

Copy link
Member

kmaehashi commented Jun 19, 2018

LGTM!
Thanks again for contribution!

@ericmjl

This comment has been minimized.

Copy link
Contributor Author

ericmjl commented Jun 19, 2018

Many thanks for your help, @kmaehashi @asi1024!

@ericmjl ericmjl deleted the ericmjl:matrix_power_v3 branch Jun 19, 2018

@kmaehashi kmaehashi changed the title implemented matrix power with tests Implement `cupy.linalg.matrix_power` Jun 20, 2018

@chainer-ci

This comment has been minimized.

Copy link

chainer-ci commented Jun 20, 2018

Jenkins CI test (for commit 3b48a94) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.