Make count_nonzero to return array #154
Merged
Conversation
|
Please check! |
| @@ -18,17 +18,15 @@ def func(xp): | |||
| m = testing.shaped_random((2, 3), xp, xp.bool_) | |||
| a = testing.shaped_random((2, 3), xp, dtype) * m | |||
| c = xp.count_nonzero(a) | |||
| self.assertIsInstance(c, int) | |||
| return c | |||
| return int(c) | |||
| self.assertEqual(func(numpy), func(cupy)) | ||
|
|
||
| @testing.for_all_dtypes() | ||
| def test_count_nonzero_zero_dim(self, dtype): | ||
| def func(xp): | ||
| a = xp.array(1.0, dtype=dtype) | ||
| c = xp.count_nonzero(a) | ||
| self.assertIsInstance(c, int) | ||
| return c | ||
| return int(c) |
niboshi
Jun 17, 2017
Member
Ditto (tests for c).
Ditto (tests for c).
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I fixed
count_nonzeroto returnndarrayinstead ofint. It is faster because there is not synchronization between CPU and GPU.see also #95