Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cupy.poly1d #3466

Merged
merged 26 commits into from Jul 3, 2020
Merged

Add cupy.poly1d #3466

merged 26 commits into from Jul 3, 2020

Conversation

Dahlia-Chehata
Copy link
Contributor

No description provided.

@Dahlia-Chehata
Copy link
Contributor Author

I'll add tests later

@kmaehashi kmaehashi added this to the v8.0.0b4 milestone Jun 22, 2020
asi1024
asi1024 reviewed Jun 23, 2020
View reviewed changes
cupy/lib/polynomial.py Outdated Show resolved Hide resolved
cupy/lib/polynomial.py Outdated Show resolved Hide resolved
asi1024
asi1024 reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@asi1024 asi1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about supporting self.get() method for explicit conversion from cupy.poly1d to numpy.poly1d in this PR?

cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
asi1024
asi1024 reviewed Jun 24, 2020
View reviewed changes
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
asi1024
asi1024 reviewed Jun 24, 2020
View reviewed changes
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
@asi1024 asi1024 modified the milestones: v8.0.0b4, v8.0.0b5 Jun 24, 2020
@emcastillo emcastillo modified the milestone: v8.0.0b5 Jun 25, 2020
asi1024
asi1024 reviewed Jun 25, 2020
View reviewed changes
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Show resolved Hide resolved
cupy/lib/polynomial.pyx Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
@asi1024 asi1024 added the cat:feature New features/APIs label Jun 25, 2020
asi1024
asi1024 reviewed Jun 26, 2020
View reviewed changes
tests/cupy_tests/lib_tests/test_polynomial.py Outdated Show resolved Hide resolved
tests/cupy_tests/lib_tests/test_polynomial.py Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
tests/cupy_tests/lib_tests/test_polynomial.py Outdated Show resolved Hide resolved
@asi1024 asi1024 added the st:awaiting-author Awaiting response from author label Jun 28, 2020
@Dahlia-Chehata
Copy link
Contributor Author

@asi1024 I think I addressed all the comments ?

asi1024
asi1024 reviewed Jun 29, 2020
View reviewed changes
tests/cupy_tests/lib_tests/test_polynomial.py Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
tests/cupy_tests/lib_tests/test_polynomial.py Outdated Show resolved Hide resolved
tests/cupy_tests/lib_tests/test_polynomial.py Outdated Show resolved Hide resolved
tests/cupy_tests/lib_tests/test_polynomial.py Outdated Show resolved Hide resolved
asi1024
asi1024 reviewed Jun 30, 2020
View reviewed changes
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Show resolved Hide resolved
asi1024
asi1024 reviewed Jun 30, 2020
View reviewed changes
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Show resolved Hide resolved
cupy/lib/polynomial.pyx Show resolved Hide resolved
cupy/lib/polynomial.pyx Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
cupy/lib/polynomial.pyx Outdated Show resolved Hide resolved
@asi1024 asi1024 removed the st:awaiting-author Awaiting response from author label Jul 1, 2020
@asi1024
Copy link
Member

asi1024 commented Jul 1, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 408cad9:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 408cad9, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member

asi1024 commented Jul 1, 2020

@Dahlia-Chehata Could you check Jenkins failure?

@Dahlia-Chehata
Copy link
Contributor Author

@asi1024 The tests pass locally. PTAL

@asi1024
Copy link
Member

asi1024 commented Jul 2, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit be65e08:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit be65e08, target branch master) failed with status FAILURE.

@asi1024
Copy link
Member

asi1024 commented Jul 3, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit e364c99:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit e364c99, target branch master) succeeded!

@asi1024
Copy link
Member

asi1024 commented Jul 3, 2020

LGTM.

@asi1024 asi1024 merged commit d9ea7c5 into cupy:master Jul 3, 2020
@Dahlia-Chehata Dahlia-Chehata deleted the poly1d branch July 6, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asi1024 asi1024 asi1024 left review comments

@leofang leofang leofang left review comments

Assignees

@asi1024 asi1024

Labels
cat:feature New features/APIs
Projects
None yet
Milestone
v8.0.0b5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Dahlia-Chehata @asi1024 @pfn-ci-bot @chainer-ci @leofang @kmaehashi @emcastillo