Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numpy_cupy_array_equal instead of numpy_cupy_array_list_equal #3599

Merged
merged 2 commits into from Jul 13, 2020

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Jul 13, 2020

Resolve conflict of #3582 and #3473.

@emcastillo
Copy link
Member

Jenkins, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 7a03901:

@emcastillo emcastillo self-assigned this Jul 13, 2020
@emcastillo emcastillo added this to the v8.0.0rc1 milestone Jul 13, 2020
@emcastillo emcastillo added st:test-and-merge (deprecated) Ready to merge after test pass. cat:test Test code / CI labels Jul 13, 2020
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 7a03901, target branch master) failed with status FAILURE.

@leofang
Copy link
Member

leofang commented Jul 13, 2020

Looks like a NumPy incompatibility?

@leofang
Copy link
Member

leofang commented Jul 13, 2020

I found using numpy_cupy_array_equal mistakenly converted NumPy's output dtypes.

@asi1024 asi1024 removed the st:test-and-merge (deprecated) Ready to merge after test pass. label Jul 13, 2020
@asi1024
Copy link
Member Author

asi1024 commented Jul 13, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 1c76ddd:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 1c76ddd, target branch master) succeeded!

@emcastillo emcastillo merged commit 7f24cb5 into cupy:master Jul 13, 2020
@asi1024 asi1024 deleted the rm-array-list-equal branch July 13, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test code / CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants