Skip to content

Xfail tests for ndarray indexing under HIP#4653

Merged
kmaehashi merged 2 commits into
cupy:masterfrom
takagi:test-hip-core-ndarray-indexing
Mar 15, 2021
Merged

Xfail tests for ndarray indexing under HIP#4653
kmaehashi merged 2 commits into
cupy:masterfrom
takagi:test-hip-core-ndarray-indexing

Conversation

@takagi

@takagi takagi commented Feb 10, 2021

Copy link
Copy Markdown
Contributor

Rel #4132.

((1, 0, 2), (2, 3, 4), (2, 0, 1)),
((-1, 0, -2), (2, 3, 4), (2, 0, 1)),
((slice(None, None, None), None), (2,), None),
((slice(-9, -10, -1),), (10,), None),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this entry new? I haven't seen that earlier (#4484 (comment)).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It newly fails when I make other entries skip. It's strange as the test should not change any state. Would you check if you can reproduce it if possible?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce this on ROCm 4.0.0 + MI50 (see my other comment).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On another MI50 machine (not the one we both have access to), I am able to see all 7 tests failing (including this (-9, -10, -1) one).

@leofang

leofang commented Feb 10, 2021

Copy link
Copy Markdown
Member

This is part of #4484 (comment).

@leofang

leofang commented Feb 14, 2021

Copy link
Copy Markdown
Member

This is super strange: On ROCm 3.5.0 + Radeon VII, all tests in test_ndarray_indexing.py passed without any problem (no need to skip), but on ROCm 4.0.0 + MI50 I saw those failures.

@leofang

leofang commented Feb 14, 2021

Copy link
Copy Markdown
Member

This is super strange: On ROCm 3.5.0 + Radeon VII, all tests in test_ndarray_indexing.py passed without any problem (no need to skip), but on ROCm 4.0.0 + MI50 I saw those failures.

All tests in test_ndarray_indexing.py passed on ROCm 4.0.0 + Radeon VII Pro (not Radeon VII).

@leofang

leofang commented Feb 14, 2021

Copy link
Copy Markdown
Member

Saw more failures on MI100...@takagi could you try to reproduce?

======================================================================= short test summary info =======================================================================
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_0_{indexes=(1, 0, 2), shape=(2, 3, 4), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_1_{indexes=(-1, 0, -2), shape=(2, 3, 4), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_2_{indexes=(1, 0, 2), shape=(2, 3, 4), transpose=(2, 0, 1)}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_3_{indexes=(-1, 0, -2), shape=(2, 3, 4), transpose=(2, 0, 1)}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_10_{indexes=(1, Ellipsis), shape=(2, 3, 4), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_13_{indexes=(None,), shape=(2, 3), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_14_{indexes=(slice(None, None, None), None), shape=(2,), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_18_{indexes=(slice(-9, -10, -1),), shape=(10,), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_27_{indexes=(slice(-4, -5, -1),), shape=(10,), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_38_{indexes=(slice(-5, -6, -1),), shape=(10,), transpose=None}::test_getitem
============================================================== 10 failed, 58 passed in 65.11s (0:01:05) ===============================================================

@leofang

leofang commented Feb 14, 2021

Copy link
Copy Markdown
Member

I feel something is wrong on these MI*** cards...

@leofang leofang mentioned this pull request Feb 14, 2021
16 tasks
@kmaehashi kmaehashi self-assigned this Feb 15, 2021
@kmaehashi kmaehashi added cat:test Test code / CI prio:high hip Topic: AMD ROCm / HIP and removed cat:test Test code / CI labels Feb 15, 2021
@takagi

takagi commented Feb 19, 2021

Copy link
Copy Markdown
Contributor Author

Saw more failures on MI100...@takagi could you try to reproduce?

It is more than those I can see on Vega 20...

@kmaehashi kmaehashi added this to the v9.0.0rc1 milestone Mar 8, 2021
@kmaehashi

Copy link
Copy Markdown
Member

pfnCI, test this please.

@kmaehashi kmaehashi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 8, 2021
@chainer-ci

Copy link
Copy Markdown
Member

Jenkins CI test (for commit cd9ca70, target branch master) failed with status FAILURE.

@takagi

takagi commented Mar 10, 2021

Copy link
Copy Markdown
Contributor Author

pfnCI, test this please.

@chainer-ci

Copy link
Copy Markdown
Member

Jenkins CI test (for commit cd9ca70, target branch master) succeeded!

@chainer-ci

Copy link
Copy Markdown
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hip Topic: AMD ROCm / HIP prio:high st:test-and-merge (deprecated) Ready to merge after test pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants