Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfail tests for ndarray indexing under HIP #4653

Merged
merged 2 commits into from Mar 15, 2021

Conversation

takagi
Copy link
Member

@takagi takagi commented Feb 10, 2021

Rel #4132.

((1, 0, 2), (2, 3, 4), (2, 0, 1)),
((-1, 0, -2), (2, 3, 4), (2, 0, 1)),
((slice(None, None, None), None), (2,), None),
((slice(-9, -10, -1),), (10,), None),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this entry new? I haven't seen that earlier (#4484 (comment)).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It newly fails when I make other entries skip. It's strange as the test should not change any state. Would you check if you can reproduce it if possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce this on ROCm 4.0.0 + MI50 (see my other comment).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On another MI50 machine (not the one we both have access to), I am able to see all 7 tests failing (including this (-9, -10, -1) one).

@leofang
Copy link
Member

leofang commented Feb 10, 2021

This is part of #4484 (comment).

@leofang
Copy link
Member

leofang commented Feb 14, 2021

This is super strange: On ROCm 3.5.0 + Radeon VII, all tests in test_ndarray_indexing.py passed without any problem (no need to skip), but on ROCm 4.0.0 + MI50 I saw those failures.

@leofang
Copy link
Member

leofang commented Feb 14, 2021

This is super strange: On ROCm 3.5.0 + Radeon VII, all tests in test_ndarray_indexing.py passed without any problem (no need to skip), but on ROCm 4.0.0 + MI50 I saw those failures.

All tests in test_ndarray_indexing.py passed on ROCm 4.0.0 + Radeon VII Pro (not Radeon VII).

@leofang
Copy link
Member

leofang commented Feb 14, 2021

Saw more failures on MI100...@takagi could you try to reproduce?

======================================================================= short test summary info =======================================================================
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_0_{indexes=(1, 0, 2), shape=(2, 3, 4), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_1_{indexes=(-1, 0, -2), shape=(2, 3, 4), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_2_{indexes=(1, 0, 2), shape=(2, 3, 4), transpose=(2, 0, 1)}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_3_{indexes=(-1, 0, -2), shape=(2, 3, 4), transpose=(2, 0, 1)}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_10_{indexes=(1, Ellipsis), shape=(2, 3, 4), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_13_{indexes=(None,), shape=(2, 3), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_14_{indexes=(slice(None, None, None), None), shape=(2,), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_18_{indexes=(slice(-9, -10, -1),), shape=(10,), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_27_{indexes=(slice(-4, -5, -1),), shape=(10,), transpose=None}::test_getitem
FAILED tests/cupy_tests/core_tests/test_ndarray_indexing.py::TestArrayIndexingParameterized_param_38_{indexes=(slice(-5, -6, -1),), shape=(10,), transpose=None}::test_getitem
============================================================== 10 failed, 58 passed in 65.11s (0:01:05) ===============================================================

@leofang
Copy link
Member

leofang commented Feb 14, 2021

I feel something is wrong on these MI*** cards...

@leofang leofang mentioned this pull request Feb 14, 2021
16 tasks
@kmaehashi kmaehashi self-assigned this Feb 15, 2021
@kmaehashi kmaehashi added cat:test Test code / CI prio:high hip Topic: AMD ROCm / HIP and removed cat:test Test code / CI labels Feb 15, 2021
@takagi
Copy link
Member Author

takagi commented Feb 19, 2021

Saw more failures on MI100...@takagi could you try to reproduce?

It is more than those I can see on Vega 20...

@kmaehashi kmaehashi added this to the v9.0.0rc1 milestone Mar 8, 2021
@kmaehashi
Copy link
Member

pfnCI, test this please.

@kmaehashi kmaehashi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 8, 2021
@chainer-ci
Copy link
Member

Jenkins CI test (for commit cd9ca70, target branch master) failed with status FAILURE.

@takagi
Copy link
Member Author

takagi commented Mar 10, 2021

pfnCI, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit cd9ca70, target branch master) succeeded!

@chainer-ci
Copy link
Member

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hip Topic: AMD ROCm / HIP prio:high st:test-and-merge (deprecated) Ready to merge after test pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants