Xfail some conditions of ndimage interpolation tests under ROCm/HIP#4878
Merged
asi1024 merged 1 commit intocupy:masterfrom Mar 23, 2021
takagi:test-hip-ndimage-interpolation
Merged
Xfail some conditions of ndimage interpolation tests under ROCm/HIP#4878asi1024 merged 1 commit intocupy:masterfrom takagi:test-hip-ndimage-interpolation
asi1024 merged 1 commit intocupy:masterfrom
takagi:test-hip-ndimage-interpolation
Conversation
Contributor
Author
|
pfnCI, test this please. |
Member
|
Jenkins CI test (for commit 574fe56, target branch master) failed with status FAILURE. |
Contributor
Author
|
pfnCI, test this please. |
Member
|
Jenkins CI test (for commit 574fe56, target branch master) failed with status FAILURE. |
Contributor
Author
|
pfnCI, test this please. |
Member
|
Jenkins CI test (for commit 574fe56, target branch master) succeeded! |
Member
|
As mentioned in #4877 (comment) only a few interpolation tests failed on ROCm 3.5.0 + Radeon VII. However, with ROCm 4.0.0 + Radeon VII Pro it went wild: output
Something is seriously wrong... |
Member
|
@asi1024 Could you take a look on this? This keeps the rocm-ci failing... |
Member
|
Jenkins, test this please |
Member
|
(CuPy headers updated, ex #4922, so get it tested again.) |
Member
|
Jenkins CI test (for commit 574fe56, target branch master) succeeded! |
asi1024
approved these changes
Mar 22, 2021
Member
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rel #4132, #4484.
Including the case that CuPy returns 255 where SciPy returns zero.