Skip to content

Xfail some conditions of signal tests under ROCm/HIP#4880

Merged
mergify[bot] merged 2 commits intocupy:masterfrom
takagi:test-hip-signaltools
Mar 18, 2021
Merged

Xfail some conditions of signal tests under ROCm/HIP#4880
mergify[bot] merged 2 commits intocupy:masterfrom
takagi:test-hip-signaltools

Conversation

@takagi
Copy link
Copy Markdown
Contributor

@takagi takagi commented Mar 13, 2021

Rel #4132, #4484.

Including fairly larger errors.

E       AssertionError: 
E       Not equal to tolerance rtol=0.001, atol=0.001
E       
E       Mismatched elements: 784 / 784 (100%)
E       Max absolute difference: 1333.3907
E       Max relative difference: 8.11097
E        x: array([[[ 1.132499e+02,  8.041714e+01,  1.015153e+02,  6.432927e+01,
E                 1.203019e+02,  1.354613e+01,  2.911143e+01, -2.381061e+01,
E                 2.635724e+01, -3.767127e+01,  1.562032e+01,  6.885651e+01,...
E        y: array([[[  30.119678,   78.50118 ,  117.3106  ,  146.02594 ,
E                 160.77292 ,  161.73344 ,  150.97159 ,  165.33815 ,
E                 196.18398 ,  194.92374 ,  152.63922 ,  113.40126 ,...

@takagi takagi added the hip Topic: AMD ROCm / HIP label Mar 13, 2021
@takagi
Copy link
Copy Markdown
Contributor Author

takagi commented Mar 13, 2021

pfnCI, test this please.

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 6979c2a, target branch master) failed with status FAILURE.

@takagi
Copy link
Copy Markdown
Contributor Author

takagi commented Mar 14, 2021

pfnCI, test this please.

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 9ee6b69, target branch master) failed with status FAILURE.

@takagi
Copy link
Copy Markdown
Contributor Author

takagi commented Mar 14, 2021

pfnCI, test this please

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 9ee6b69, target branch master) failed with status FAILURE.

@takagi
Copy link
Copy Markdown
Contributor Author

takagi commented Mar 15, 2021

test_copyto_multigpu is known to be fleaky and is not relevant to this change.

@emcastillo
Copy link
Copy Markdown
Member

Probably all these tests have issues related to memory fences/warp sizes etc.

@emcastillo
Copy link
Copy Markdown
Member

Jenkins, test this please

@emcastillo emcastillo added this to the v9.0.0rc1 milestone Mar 18, 2021
@emcastillo emcastillo added the st:test-and-merge (deprecated) Ready to merge after test pass. label Mar 18, 2021
@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit 9ee6b69, target branch master) succeeded!

@mergify mergify Bot merged commit e006c05 into cupy:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hip Topic: AMD ROCm / HIP prio:high st:test-and-merge (deprecated) Ready to merge after test pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants