Do not use with device in code base#5963
Merged
kmaehashi merged 4 commits intocupy:masterfrom Nov 1, 2021
Merged
Conversation
Member
Author
|
Jenkins, test this please |
Member
|
Jenkins CI test (for commit 1a1ac3a, target branch master) succeeded! |
Member
Author
|
/test |
Member
|
|
Member
Author
|
Jenkins, test this please |
Member
|
Jenkins CI test (for commit 12cb4e2, target branch master) succeeded! |
Member
Author
|
Jenkins, test this please |
Member
|
Jenkins CI test (for commit f896ea6, target branch master) succeeded! |
kmaehashi
added
blocking
kmaehashi
changed the title
with device in code basewith device in code base
This was referenced Nov 2, 2021
Member
|
Jenkins CI test (for commit f896ea6, target branch master) succeeded! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5943
Do not use the context manager since mixing it with internal calls will mess the user set device.