Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadd use of dns over https (doh) #30
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
LGTM. Let's see what it can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pauldreik commentedSep 14, 2019
I managed to get the functions in doh.c exercised with this branch. It would be nice to see oss-fuzz cover also that function.
If you merge soon, it will be interesting to see if oss-fuzz finds the bug in curl/curl#4352 before it has been merged into master. It may be difficult to randomly come up with a 480 something input while also matching the TLV and length, but let's see!