Skip to content
Permalink
Browse files

docs: Fix links to OpenSSL docs

OpenSSL changed their manual locations and does not redirect to the new
locations.

Bug: https://curl.haxx.se/mail/lib-2019-06/0056.html
Reported-by: Daniel Stenberg
  • Loading branch information...
jay committed Jun 30, 2019
1 parent 44b5468 commit 3609ab3147b11118319da4584a0c72f638697838
Showing with 6 additions and 7 deletions.
  1. +1 −1 docs/examples/threaded-ssl.c
  2. +5 −4 docs/libcurl/libcurl-thread.3
  3. +0 −2 lib/vtls/openssl.c
@@ -29,7 +29,7 @@
* (libgcrypt) so far.
*
* OpenSSL docs for this:
* https://www.openssl.org/docs/crypto/threads.html
* https://www.openssl.org/docs/man1.0.2/man3/CRYPTO_num_locks.html
* gcrypt docs for this:
* https://gnupg.org/documentation/manuals/gcrypt/Multi_002dThreading.html
*/
@@ -41,14 +41,15 @@ then of course using the underlying SSL library multi-threaded and those libs
might have their own requirements on this issue. You may need to provide one
or two functions to allow it to function properly:
.IP OpenSSL
OpenSSL 1.1.0 "can be safely used in multi-threaded applications provided that
support for the underlying OS threading API is built-in."
OpenSSL 1.1.0+ "can be safely used in multi-threaded applications provided that
support for the underlying OS threading API is built-in." In that case the
engine is used by libcurl in a way that is fully thread-safe.

https://www.openssl.org/docs/manmaster/crypto/threads.html#DESCRIPTION
https://www.openssl.org/docs/man1.1.0/man3/CRYPTO_THREAD_run_once.html#DESCRIPTION

OpenSSL <= 1.0.2 the user must set callbacks.

https://www.openssl.org/docs/man1.0.2/crypto/threads.html#DESCRIPTION
https://www.openssl.org/docs/man1.0.2/man3/CRYPTO_set_locking_callback.html#DESCRIPTION

https://curl.haxx.se/libcurl/c/opensslthreadlock.html

@@ -3280,7 +3280,6 @@ static CURLcode pkp_pin_peer_pubkey(struct Curl_easy *data, X509* cert,
if(len1 < 1)
break; /* failed */

/* https://www.openssl.org/docs/crypto/buffer.html */
buff1 = temp = malloc(len1);
if(!buff1)
break; /* failed */
@@ -3302,7 +3301,6 @@ static CURLcode pkp_pin_peer_pubkey(struct Curl_easy *data, X509* cert,
result = Curl_pin_peer_pubkey(data, pinnedpubkey, buff1, len1);
} while(0);

/* https://www.openssl.org/docs/crypto/buffer.html */
if(buff1)
free(buff1);

0 comments on commit 3609ab3

Please sign in to comment.
You can’t perform that action at this time.