From b4043706eba8436cf82815277af9153c687757c7 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 22 Jun 2017 10:31:03 +0200 Subject: [PATCH] CONTRIBUTE.md: mention the out-of-tree build test too --- docs/CONTRIBUTE.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/CONTRIBUTE.md b/docs/CONTRIBUTE.md index 7d3c2e07336c91..536a9ceb3f0b3a 100644 --- a/docs/CONTRIBUTE.md +++ b/docs/CONTRIBUTE.md @@ -157,14 +157,15 @@ lists. Every pull request submitted will automatically be tested in several different ways. Every pull request is verfied that: - - ... the code still builds, warning-free, on Linux and macOS, with both + - ... it still builds, warning-free, on Linux and macOS, with both clang and gcc - - ... the code still builds fine on Windows with several MSVC versions - - ... the code still builds with cmake on Linux, with gcc and clang - - ... the code follows rudimentary code style rules + - ... it still builds fine on Windows with several MSVC versions + - ... it still builds with cmake on Linux, with gcc and clang + - ... it follows rudimentary code style rules - ... the test suite still runs 100% fine - ... the release tarball (the "dist") still works - - ... the code coverage doesn't shrink drastically + - ... it builds fine in-tree as well as out-of-tree + - ... code coverage doesn't shrink drastically If the pull-request fails one of these tests, it will show up as a red X and you are expected to fix the problem. If you don't understand whan the issue is