Skip to content
Permalink
Browse files

singlesocket: use separate variable for inner loop

An inner loop within the singlesocket() function wrongly re-used the
variable for the outer loop which then could cause an infinite
loop. Change to using a separate variable!

Reported-by: Eric Wu
Fixes #3970
Closes #3973
  • Loading branch information...
bagder committed May 31, 2019
1 parent d3d04a8 commit c36f42839d88b0e4c938e80ebd5da4c765b0264e
Showing with 4 additions and 4 deletions.
  1. +4 −4 lib/multi.c
@@ -2252,14 +2252,14 @@ static CURLMcode singlesocket(struct Curl_multi *multi,
actions[i] = action;
if(entry) {
/* check if new for this transfer */
for(i = 0; i< data->numsocks; i++) {
if(s == data->sockets[i]) {
prevaction = data->actions[i];
int j;
for(j = 0; j< data->numsocks; j++) {
if(s == data->sockets[j]) {
prevaction = data->actions[j];
sincebefore = TRUE;
break;
}
}

}
else {
/* this is a socket we didn't have before, add it to the hash! */

0 comments on commit c36f428

Please sign in to comment.
You can’t perform that action at this time.