Skip to content
Permalink
Browse files

examples/htmltitle: use C++ casts between pointer types

Compilers and static analyzers warn about using C-style casts here.

Closes #3975
  • Loading branch information...
MarcelRaad committed May 25, 2019
1 parent 992083b commit e1f3aaea0cf7d404d44e0dbdf608b1260fae6e1a
Showing with 7 additions and 7 deletions.
  1. +7 −7 docs/examples/htmltitle.cpp
@@ -136,9 +136,9 @@ static void StartElement(void *voidContext,
const xmlChar *name,
const xmlChar **attributes)
{
Context *context = (Context *)voidContext;
Context *context = static_cast<Context *>(voidContext);

if(COMPARE((char *)name, "TITLE")) {
if(COMPARE(reinterpret_cast<char *>(name), "TITLE")) {
context->title = "";
context->addTitle = true;
}
@@ -152,9 +152,9 @@ static void StartElement(void *voidContext,
static void EndElement(void *voidContext,
const xmlChar *name)
{
Context *context = (Context *)voidContext;
Context *context = static_cast<Context *>(voidContext);

if(COMPARE((char *)name, "TITLE"))
if(COMPARE(reinterpret_cast<char *>(name), "TITLE"))
context->addTitle = false;
}

@@ -167,7 +167,7 @@ static void handleCharacters(Context *context,
int length)
{
if(context->addTitle)
context->title.append((char *)chars, length);
context->title.append(reinterpret_cast<char *>(chars), length);
}

//
@@ -178,7 +178,7 @@ static void Characters(void *voidContext,
const xmlChar *chars,
int length)
{
Context *context = (Context *)voidContext;
Context *context = static_cast<Context *>(voidContext);

handleCharacters(context, chars, length);
}
@@ -191,7 +191,7 @@ static void cdata(void *voidContext,
const xmlChar *chars,
int length)
{
Context *context = (Context *)voidContext;
Context *context = static_cast<Context *>(voidContext);

handleCharacters(context, chars, length);
}

0 comments on commit e1f3aae

Please sign in to comment.
You can’t perform that action at this time.