Skip to content

Commit

Permalink
url: Fix CURLOPT_MAXAGE_CONN time comparison
Browse files Browse the repository at this point in the history
Old connections are meant to expire from the connection cache after
CURLOPT_MAXAGE_CONN seconds. However, they actually expire after 1000x
that value. This occurs because a time value measured in milliseconds is
accidentally divided by 1M instead of by 1,000.

Closes #4013
  • Loading branch information
Cliff Crosland authored and jay committed Jun 12, 2019
1 parent 29177f4 commit f67009d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/url.c
Expand Up @@ -975,7 +975,7 @@ static bool conn_maxage(struct Curl_easy *data,
timediff_t idletime = Curl_timediff(now, conn->lastused);
idletime /= 1000; /* integer seconds is fine */

if(idletime/1000 > data->set.maxage_conn) {
if(idletime > data->set.maxage_conn) {
infof(data, "Too old connection (%ld seconds), disconnect it\n",
idletime);
return TRUE;
Expand Down

0 comments on commit f67009d

Please sign in to comment.