Skip to content
Commits on Jun 15, 2012
  1. @bagder

    Curl_rtsp_parseheader: avoid useless malloc/free

    bagder committed
    Coverity actually pointed out flawed logic in the previous call to
    Curl_strntoupper() where the code used sizeof() of a pointer to pass in
    a size argument. That code still worked since it only needed to
    uppercase 4 letters. Still, the entire malloc/uppercase/free sequence
    was pointless since the code has already matched the string once in the
    condition that starts the block of code.
Commits on Oct 21, 2011
  1. @bagder

    curl_multi_fdset: correct fdset with FTP PORT use

    bagder committed
    After a PORT has been issued, and the multi handle would switch to the
    CURLM_STATE_DO_MORE state (which is unique for FTP), libcurl would
    return the wrong fdset to wait for when curl_multi_fdset() is
    called. The code would blindly assume that it was waiting for a connect
    of the second connection, while that isn't true immediately after the
    PORT command.
    Also, the function multi.c:domore_getsock() was highly FTP-centric and
    therefore ugly to keep in protocol-agnostic code. I solved this problem
    by introducing a new function pointer in the Curl_handler struct called
    domore_getsock() which is only called during the DOMORE state for
    protocols that set that pointer.
    The new ftp.c:ftp_domore_getsock() function now returns fdset info about
    the control connection's command/response handling while such a state is
    in use, and goes over to waiting for a writable second connection first
    once the commands are done.
    The original problem could be seen by running test 525 and checking the
    time stamps in the FTP server log. I can verify that this fix at least
    fixes this problem.
    Reported by: Gokhan Sengun
Commits on Sep 26, 2011
  1. @yangtse
Commits on Sep 25, 2011
  1. @yangtse

    allow write callbacks to indicate OOM to libcurl

    yangtse committed
    Allow (*curl_write_callback) write callbacks to return
    CURL_WRITEFUNC_OUT_OF_MEMORY to properly indicate libcurl of OOM conditions
    inside the callback itself.
Commits on Aug 14, 2011
  1. @bagder
Commits on May 5, 2011
  1. @bagder

    RTSP: cleanups

    bagder committed
    Made several functions static
    Made one function defined to nothing when RTSP is disabled to avoid
    the #ifdefs in code.
    Removed explicit rtsp.h includes
  2. @bagder

    RTSP: convert protocol-specific checks to generic

    bagder committed
    Add a 'readwrite' function to the protocol handler struct and use that
    for the extra readwrite functionality RTSP needs.
Commits on Apr 27, 2011
  1. @bagder

    source cleanup: unify look, style and indent levels

    bagder committed
    By the use of a the new lib/ script that checks that our
    basic source style rules are followed.
Commits on Apr 19, 2011
  1. @bagder


    bagder committed
    Massively reduce #ifdefs all over (23 #ifdef lines less so far)
    Moved conversion-specific code to non-ascii.c
Commits on Apr 11, 2011
  1. @bagder

    checkconnection: don't call with NULL pointer

    bagder committed
    When checking if an existing RTSP connection is alive or not, the
    checkconnection function might be called with a SessionHandle pointer
    being NULL and then referenced causing a crash. This happened only using
    the multi interface.
    Reported by: Tinus van den Berg
Commits on Mar 23, 2011
  1. @bagder

    rtsp: move protocol code to dedicated file

    bagder committed
    The RTSP-specific function for checking for "dead" connection is better
    located in rtsp.c. The code using this is now written without #ifdefs as
    the function call is instead turned into a macro (in rtsp.h) when RTSP
    is disabled.
Commits on Mar 14, 2011
  1. @bagder

    protocols: use CURLPROTO_ internally

    bagder committed
    The PROT_* set of internal defines for the protocols is no longer
    used. We now use the same bits internally as we have defined in the
    public header using the CURLPROTO_ prefix. This is for simplicity and
    because the PROT_* prefix was already used duplicated internally for a
    set of KRB4 values.
    The PROTOPT_* defines were moved up to just below the struct definition
    within which they are used.
  2. @bagder

    protocol handler: added flags field

    bagder committed
    The protocol handler struct got a 'flags' field for special information
    and characteristics of the given protocol.
    This now enables us to move away central protocol information such as
    CLOSEACTION and DUALCHANNEL from single defines in a central place, out
    to each protocol's definition. It also made us stop abusing the protocol
    field for other info than the protocol, and we could start cleaning up
    other protocol-specific things by adding flags bits to set in the
    handler struct.
    The "protocol" field connectdata struct was removed as well and the code
    now refers directly to the conn->handler->protocol field instead. To
    make things work properly, the code now always store a conn->given
    pointer that points out the original handler struct so that the code can
    learn details from the original protocol even if conn->handler is
    modified along the way - for example when switching to go over a HTTP
Commits on Dec 6, 2010
  1. @kdudka

    url: provide dead_connection flag in Curl_handler::disconnect

    kdudka committed
    It helps to prevent a hangup with some FTP servers in case idle session
    timeout has exceeded.  But it may be useful also for other protocols
    that send any quit message on disconnect.  Currently used by FTP, POP3,
    IMAP and SMTP.
Commits on Sep 6, 2010
  1. @kdudka
  2. @kdudka
Commits on Apr 16, 2010
  1. @bagder

    Curl_setup_transfer: no longer returns anything

    bagder committed
    This function could only return CURLE_OK and by changing it to
    a void instead, we can simplify code all over.
Commits on Mar 24, 2010
  1. @cconroy @bagder

    Fix RTSP GET_PARAMETER empty and non-empty operation.

    cconroy committed with bagder
    Test coverage included. Thanks to Massimo Callegari for the bug report
  2. @bagder

    remove the CVSish $Id$ lines

    bagder committed
Commits on Feb 6, 2010
  1. @yangtse

    OOM handling fix

    yangtse committed
  2. @yangtse

    OOM handling fix

    yangtse committed
Commits on Feb 3, 2010
  1. @yangtse

    Fix OOM handling

    yangtse committed
  2. @yangtse
Commits on Feb 1, 2010
  1. @yangtse

    Conroy's fix to make the code match with the RTP documentation regarding

    yangtse committed
    writing out the whole header. The docs say it writes the whole header,
    but the code (before this patch) did not write out the leading $.
Commits on Jan 28, 2010
  1. @yangtse

    fix printf-style format strings

    yangtse committed
  2. @yangtse
Commits on Jan 25, 2010
  1. @yangtse

    fix compiler warning

    yangtse committed
Commits on Jan 23, 2010
  1. @dfandrich
Commits on Jan 22, 2010
  1. @yangtse
Commits on Jan 21, 2010
  1. @bagder

    Chris Conroy brought support for RTSP transfers, and with it comes 8(…

    bagder committed
    …!) new
    libcurl options for controlling what to get and how to receive posssibly
    interleaved RTP data. Initial commit.
Something went wrong with that request. Please try again.