-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Hyperlink escape sequence causes bad output in Ubuntu 16 LTS terminal #10428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What terminal emulator does this use? On all the ones I tried, the escape
sequence is either interpreted correctly or ignored and not displayed.
|
Gnome Terminal 3.18.3 + VTE 0.42.5 |
@dfandrich is this only because of an older gnome terminal and we can just ask users to run a later version or is there anything more clever we can here? |
OSC 8 support was added to Gnome Terminal 6 years ago in ver. 3.25.1. There's a list tracking support in terminal emulators on this page. The OSC 8 spec also says
It sounds like there may have been a bug in Gnome Terminal that didn't do this, but other terminal emulators, even those that don't support OSC 8, should ignore the extra data and that is what I found in my testing. That spec page lists four terminal emulators that still didn't work properly as of 3 years ago, but all of them are working (mostly) today in their latest versions. I can't think how we could easily and reliably detect whether a terminal emulator is buggy or not and dynamically enable this. xterm-style answerback strings might theoretically do it if those were still a thing, otherwise it would take linking with an X11 library and even that wouldn't work all the time. My suggestion would be to just use --no-styled-output on those few cases where it doesn't work, or better yet, upgrade your terminal emulator since there aren't any known buggy implementations left according to that page. |
That page also says VTE versions up to 0.48.1 (6 years ago) have bugs so I've submitted #11071 to test VTE_VERSION env var |
- Disable hyperlink formatting for the 'Location:' header value in VTE 0.48.1 and earlier, since it is buggy in some of those versions. Prior to this change those terminals may show the location header value as gibberish or show it twice. Ref: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#backward-compatibility Fixes curl#10428 Closes #xxxx
- Disable hyperlink formatting for the 'Location:' header value in VTE 0.48.1 and earlier, since it is buggy in some of those versions. Prior to this change those terminals may show the location header value as gibberish or show it twice. Ref: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#backward-compatibility Fixes curl#10428 Closes curl#11071
I did this
In Ubuntu 16 LTS terminal the location header has unrecognized escape sequences and duplicate URL.
/cc @dfandrich
The text was updated successfully, but these errors were encountered: