Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CURLOPT_PROGRESSDATA man page: clientp vs userp #10434

Closed
grrtrr opened this issue Feb 7, 2023 · 0 comments
Closed

CURLOPT_PROGRESSDATA man page: clientp vs userp #10434

grrtrr opened this issue Feb 7, 2023 · 0 comments
Assignees
@bagder
Labels
documentation

Comments

@grrtrr
Copy link

grrtrr commented Feb 7, 2023

The text says

struct memory *progress = (struct progress *)userp;

From the context, it seems it should be

struct memory *progress = (struct progress *)clientp;

This also happens in the CURLOPT_XFERINFODATA man page.
@bagder bagder self-assigned this Feb 7, 2023
bagder added a commit that referenced this issue Feb 7, 2023
@bagder
man pages: call the custom user pointer 'clientp' consistently
b22adf0 
The variable had a few different names. Now try to use 'clientp'
consistently for all man pages using a custom pointer set by the
application.

Reported-by: Gerrit Renker

Fixes #10434
@bagder bagder mentioned this issue Feb 7, 2023
Closed
@bagder bagder closed this as completed in 1695fcf Feb 7, 2023
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@bagder @bch
man pages: call the custom user pointer 'clientp' consistently
f287a7a 
The variable had a few different names. Now try to use 'clientp'
consistently for all man pages using a custom pointer set by the
application.

Reported-by: Gerrit Renker

Fixes curl#10434
Closes curl#10435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

man pages: call the custom user pointer 'clientp' consistently curl/curl
2 participants
@bagder @grrtrr