Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build warning in old version of visual studio #10449

Closed
jay opened this issue Feb 9, 2023 · 2 comments
Closed

build warning in old version of visual studio #10449

jay opened this issue Feb 9, 2023 · 2 comments
Assignees
@icing
Labels
build

Comments

@jay
Copy link
Member

jay commented Feb 9, 2023

build warning in old version of visual studio, in cf_h2_send -1 is assigned to a size_t in a bunch of places, eg len = -1

........\lib\http2.c(1978): warning C4245: '=' : conversion from 'int' to 'size_t', signed/unsigned mismatch

I'm using a pre generated build configuration from the projects directory with enabled http2 added. Possibly needs ssize_t sent or I can just ignore it. I notice none of the CI builds show this warning.

@icing
@jay jay added the build label Feb 9, 2023
@icing
Copy link
Contributor

icing commented Feb 9, 2023

Indeed, that does not look sound. I'll add a ssize_t for the return value.

icing added a commit to icing/curl that referenced this issue Feb 9, 2023
@icing
nghttp2, better handling of cf_h2_send() return value.
0f9ab8f 
- use explicit ssize_t return var instead of mis-using size_t len for -1 returns.

Refs curl#10449
@icing icing mentioned this issue Feb 9, 2023
Closed
@icing
Copy link
Contributor

icing commented Feb 9, 2023

Should be addressed in #10450.

icing added a commit to icing/curl that referenced this issue Feb 27, 2023
@icing
nghttp2, better handling of cf_h2_send() return value.
da64dd2 
- use explicit ssize_t return var instead of mis-using size_t len for -1 returns.

Refs curl#10449
icing added a commit to icing/curl that referenced this issue Feb 27, 2023
@icing
Fixing busy loop on large uploads for HTTP/2.
97633e8 
- refs curl#10449 with improvements in h2_cf_send() and nwritten return code
  handling. Cherry picked and improved after review by @jay
- setting KEEP_SEND_PAUSE flags when exhausting remote HTTP/2 window
  size of a stream.
- clearing KEEP_SEND_PAUSE when receiving HTTP/2 window updates
  on a paused stream.
@vszakats vszakats mentioned this issue Feb 27, 2023
Closed
@jay jay closed this as completed in d9ccc75 Mar 1, 2023
@dfandrich dfandrich mentioned this issue Mar 24, 2023
Closed
bch pushed a commit to bch/curl that referenced this issue Jul 19, 2023
@icing @bch
http2: fix upload busy loop
da9a893 
- Set KEEP_SEND_PAUSE when exhausting remote HTTP/2 window size of a
  stream.

- Clear KEEP_SEND_PAUSE when receiving HTTP/2 window updates on a paused
  stream.

- Also fix http2 send compiler warnings reported in curl#10449.

Prior to this change, starting in 71b7e01 which precedes 7.88.0,
libcurl may eat CPU during HTTP/2 upload.

Reported-by: Jay Satiro

Fixes curl#10449
Fixes curl#10618
Closes curl#10627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icing icing

Labels
build
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icing @jay