-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in the HTTP2 framing layer #10634
Comments
- refs curl#10634 where errors in the HTTP/2 framing layer are observed. - the bug was that on connection reuse, the code attempted to switch in yet another layer of HTTP/2 handling instead of detecting that this was already in place. - added pytest testcase reproducing the issue.
Thanks for the report. I made a test case and fix in #10643. As to my analysis, the error should have always happened on the 2nd URL that used the same connection. |
Yes it's possible that is what happened. My actual case is some custom code which is quite a lot more complicated, and so I tried to reduce it down to something that happens with only the I have tested your proposed patch and it works fine for me, both with |
- refs curl#10634 where errors in the HTTP/2 framing layer are observed. - the bug was that on connection reuse, the code attempted to switch in yet another layer of HTTP/2 handling instead of detecting that this was already in place. - added pytest testcase reproducing the issue. Reported-by: rwmjones on github Fixes curl#10634 Closes curl#10643
I did this
I set up an Apache 2.4.55 server to serve a file over HTTP/2. When connecting repeatedly to the server using the
curl
command, I get the following error (usually at random, but below it happened for the first URL):I expected the following
No error.
curl/libcurl version
This happens with curl @ commit 788c6b3
I bisected the problem and it was introduced by commit 6711582
Reverting curl back to commit b7aaf07 (the commit before 6711582) fixes the problem.
operating system
Fedora Rawhide
The text was updated successfully, but these errors were encountered: