If I don't use -j and use use just make in the tests directory, it seems to build just fine.
If I revert the above mention commit, it also makes the build work again.
/usr/bin/ld: unit1305.o: warning: relocation against `unitfail' in read-only section `.text'
/usr/bin/ld: unit1304.o: warning: relocation against `unitfail' in read-only section `.text'
/usr/bin/ld: unit1302.o: warning: relocation against `unitfail' in read-only section `.text'
/usr/bin/ld: unit1300.o: warning: relocation against `unitfail' in read-only section `.text'
/usr/bin/ld: unit1303.o: warning: relocation against `unitfail' in read-only section `.text'
/usr/bin/ld: unit1305.o: in function `test':
/home/dast/src/curl/tests/unit/unit1305.c:114: undefined reference to `unitfail'
/usr/bin/ld: /home/dast/src/curl/tests/unit/unit1305.c:114: undefined reference to `unitfail'
/usr/bin/ld: /home/dast/src/curl/tests/unit/unit1305.c:122: undefined reference to `unitfail'
/usr/bin/ld: /home/dast/src/curl/tests/unit/unit1305.c:122: undefined reference to `unitfail'
/usr/bin/ld: /home/dast/src/curl/tests/unit/unit1305.c:127: undefined reference to `unitfail'
/usr/bin/ld: unit1305.o:/home/dast/src/curl/tests/unit/unit1305.c:127: more undefined references to `unitfail' follow
/usr/bin/ld: unit1330.o: warning: relocation against `unitfail' in read-only section `.text'
/usr/bin/ld: unit1323.o: warning: relocation against `unitfail' in read-only section `.text'
/usr/bin/ld: unit1304.o: in function `test':
/home/dast/src/curl/tests/unit/unit1304.c:50: undefined reference to `unitfail'
/usr/bin/ld: /home/dast/src/curl/tests/unit/unit1304.c:50: undefined reference to `unitfail'
The text was updated successfully, but these errors were encountered:
Using CPPFLAGS sometimes caused odd compile issues when building tests
with parallel make and AM_CPPFILES is the right flag, anyway.
Follow-up to cb7ed5a
Ref #10749
The only difference used to be global variable used in unittest tests.
After cb7ed5a removed individual flag overrides for the unittests, first.c
was no longer recompiled for unit tests to include the flag, so whether it
worked or gave a link error depended on whether it was compiled in
libtest or unittest first.
Fixes#10749
I did this
make -C tests -sj
to build the test suite and tests using a parallel buildIt currently fails on master, see partial error output below. I bisected the offending commit to this:
commit cb7ed5a
If I don't use
-j
and use use justmake
in thetests
directory, it seems to build just fine.If I revert the above mention commit, it also makes the build work again.
The text was updated successfully, but these errors were encountered: