Remove Mac poll from cmake build #1089

Closed
jay opened this Issue Oct 29, 2016 · 1 comment

Projects

None yet

2 participants

@jay
Member
jay commented Oct 29, 2016 edited

Ref #1057

poll doesn't work right on some Mac versions so it's been disabled for all Mac in the autotools build. My understanding similar changes are needed for the cmake build. It was suggested I start a separate issue for that, so here's a c&p of my question in that thread:


for example should it be

if(NOT APPLE)
check_symbol_exists(poll          "${CURL_INCLUDES}" HAVE_POLL)
endif()

also should there be some sort of failsafe in setup like

#if defined(__APPLE__) && (defined(HAVE_POLL) || defined(HAVE_POLL_FINE))
#error "failsafe: we don't allow poll on apple, build config should have detected this"
#endif

this way it doesn't get away from us as more build systems are added or say for example someone adds HAVE_POLL_FINE to cmake


basically the idea is we want to make sure no poll on mac

@jzakrzewski @snikulov @Lekensteyn

@jay jay added the cmake label Oct 29, 2016
@snikulov
Member

@jay Unfortunatelly, I have no Mac access, so I'm unable to help with this, sorry.

@Lekensteyn Lekensteyn added a commit to Lekensteyn/curl that referenced this issue Oct 30, 2016
@Lekensteyn Lekensteyn cmake: disable poll for macOS
Mirrors the autotools behavior introduced with curl-7_50_3-83-ga34c7ce.

Fixes #1089
4ea2b41
@Lekensteyn Lekensteyn added a commit that closed this issue Nov 6, 2016
@Lekensteyn Lekensteyn cmake: disable poll for macOS
Mirrors the autotools behavior introduced with curl-7_50_3-83-ga34c7ce.

Fixes #1089
6aa9cfa
@Lekensteyn Lekensteyn closed this in 6aa9cfa Nov 6, 2016
@saprykin saprykin added a commit to saprykin/plibsys that referenced this issue Dec 25, 2016
@saprykin saprykin mac: Do not use poll() as it can be broken 2c05022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment