New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mac poll from cmake build #1089

Closed
jay opened this Issue Oct 29, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jay
Member

jay commented Oct 29, 2016

Ref #1057

poll doesn't work right on some Mac versions so it's been disabled for all Mac in the autotools build. My understanding similar changes are needed for the cmake build. It was suggested I start a separate issue for that, so here's a c&p of my question in that thread:


for example should it be

if(NOT APPLE)
check_symbol_exists(poll          "${CURL_INCLUDES}" HAVE_POLL)
endif()

also should there be some sort of failsafe in setup like

#if defined(__APPLE__) && (defined(HAVE_POLL) || defined(HAVE_POLL_FINE))
#error "failsafe: we don't allow poll on apple, build config should have detected this"
#endif

this way it doesn't get away from us as more build systems are added or say for example someone adds HAVE_POLL_FINE to cmake


basically the idea is we want to make sure no poll on mac

@jzakrzewski @snikulov @Lekensteyn

@jay jay added the cmake label Oct 29, 2016

@snikulov

This comment has been minimized.

Member

snikulov commented Oct 29, 2016

@jay Unfortunatelly, I have no Mac access, so I'm unable to help with this, sorry.

Lekensteyn added a commit to Lekensteyn/curl that referenced this issue Oct 30, 2016

cmake: disable poll for macOS
Mirrors the autotools behavior introduced with curl-7_50_3-83-ga34c7ce.

Fixes curl#1089

@Lekensteyn Lekensteyn closed this in 6aa9cfa Nov 6, 2016

saprykin added a commit to saprykin/plibsys that referenced this issue Dec 25, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.