Skip to content

Not all compilers support -Werror=partial-availability #1104

Closed
Closed
Not all compilers support -Werror=partial-availability#1104
Labels
build

Description

@bemoody
bemoody
opened on Nov 3, 2016

Recently, curl's configure script was changed to unconditionally
add '-Werror=partial-availability' to the CFLAGS if $host_os is
darwin*.

This breaks compilation using diorcety's crosstool-ng, which
doesn't know about that option. And it probably breaks lots of
other older compilers.

Please check that the C compiler actually understands a given
option before adding it to the CFLAGS. For example:

save_CFLAGS=$CFLAGS
AC_MSG_CHECKING([whether $CC accepts -Werror=partial-availability])
CFLAGS="$CFLAGS -Werror=partial-availability"
AC_COMPILE_IFELSE([AC_LANG_PROGRAM()],
  [AC_MSG_RESULT([yes])],
  [AC_MSG_RESULT([no])
   CFLAGS=$save_CFLAGS])

Activity

  1. bagder
    added
    build
    on Nov 3, 2016

  2. bagder commented on Nov 3, 2016

    @bagder
    bagder
    on Nov 3, 2016
    Member

    So what about -mmacosx-version-min, is that also going to cause problems?

  3. bagder commented on Nov 3, 2016

    @bagder
    bagder
    on Nov 3, 2016
    Member

    Just checking if -Werror=partial-availability works:

    diff --git a/acinclude.m4 b/acinclude.m4
index f959e3d..2abae8d 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -3230,9 +3230,16 @@ AC_DEFUN([CURL_MAC_CFLAGS], [
     if test -z "$min"; then
       AC_MSG_RESULT([set by user])
     else
       AC_MSG_RESULT([$min set])
     fi
+
+    old_CFLAGS=$CFLAGS
     CFLAGS="$CFLAGS -Werror=partial-availability"
+    AC_MSG_CHECKING([whether $CC accepts -Werror=partial-availability])
+    AC_COMPILE_IFELSE([AC_LANG_PROGRAM()],
+      [AC_MSG_RESULT([yes])],
+      [AC_MSG_RESULT([no])
+      CFLAGS=$old_CFLAGS])
   fi

 ])

  4. bemoody commented on Nov 3, 2016

    @bemoody
    bemoody
    on Nov 3, 2016
    Author

    -mmacosx-version-min works for me; it seems to me that's been around for quite a while so it's probably safe. But I'm not sure.

  5. bagder
    closed this as completedin 6724242on Nov 3, 2016

  6. bagder commented on Nov 3, 2016

    @bagder
    bagder
    on Nov 3, 2016
    Member

    Thanks! Ok let's leave -mmacosx-version-min for now and see if people report anything. Pushed the fix for -Werror=partial-availability.

  7. lock
    locked as resolved and limited conversation to collaborators on May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    build

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions