New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation warnings when building for iOS min version 13 #11098
Comments
Happens with macOS builds as well. They can be silenced with the C flag |
I'm not very fluent in macOS specifics, but "Use Network.framework." seems to imply that a rather major effort would be necessary to address these in other ways than just inhibiting the warning messages. I don't see this happening anytime soon. |
Indeed, it seems Apple deprecated SecureTransport as-is: ...I stand corrected with "temporary"! |
For the warnings in md4.c and md5.c, we don't use the system functions anymore for recent macOS since 2998749 because of the possible warnings-as-errors. We could do the same for iOS. Also, we can probably include MD4 support only if For SecureTransport, the only actionable warning seems to be this one:
If you don't want functions deprecated by Apple to be used, don't choose a framework deprecated by Apple as an SSL backend. |
Turns out the macOS case I mentioned is not related to SecureTransport, but to after
|
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`, so let's use this here too. Ref: curl#11098
They are marked as deprecated in iOS 13.0, which might result in warnings-as-errors. Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to be what's currently used. Ref: curl#11098
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`, so let's use this here too. Ref: curl#11098 Closes curl#11102
They are marked as deprecated in iOS 13.0, which might result in warnings-as-errors. Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to be what's currently used. Ref: curl#11098 Closes curl#11102
Its only usage in curl_ntlm_core.c is guarded by `USE_CURL_NTLM_CORE`, so let's use this here too. Ref: curl#11098 Closes curl#11102
They are marked as deprecated in iOS 13.0, which might result in warnings-as-errors. Also, use `*_MIN_REQUIRED` instead of `*_MIN_ALLOWED`, which seems to be what's currently used. Bug: curl#11098 Closes curl#11102
The md4/md5 part should be addressed by #11102. I cannot fix the |
Thank you for checking this and for the great efforts Nice to see that you addressed "This function is cryptographically broken and should not be used in security contexts" warnings
I understand. I can use Secure Transport as SSL backend (or other SSL supported library: OpenSSL, GnuTLS, NSS, wolfSSL, mbedTLS, Schannel) but I can't use "Netwrok.Framework" because it is not supported as SSL backend library and it is something not planned to add in a near future. Thanks again |
I did this
Compiling curl for iOS and min versions iOS 13
configure: Configured to build curl/libcurl:
Compilation warnings:
I expected the following
No warnings in the compilation.
curl/libcurl version
Compiling version 8.0.1 (probably happens with previous versions too)
operating system
Chip: Apple M1 Max
macOS 13.3.1 (a) (22E772610a)
Xcode: Version 14.3 (14E222b)
Darwin 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 arm64
The text was updated successfully, but these errors were encountered: